Re: [Xen-devel] [PATCH 6/8] drm/xen: Simplify fb_create

2019-11-19 Thread Daniel Vetter
On Fri, Nov 15, 2019 at 10:33:24AM +, Oleksandr Andrushchenko wrote: > On 11/15/19 11:21 AM, Daniel Vetter wrote: > > The current code is a pretty good wtf moment, since we drop the > > reference before we use it. It's not a big deal, because a) we only > > use the pointer, so doesn't blow up

Re: [Xen-devel] [PATCH 6/8] drm/xen: Simplify fb_create

2019-11-15 Thread Oleksandr Andrushchenko
On 11/15/19 11:21 AM, Daniel Vetter wrote: > The current code is a pretty good wtf moment, since we drop the > reference before we use it. It's not a big deal, because a) we only > use the pointer, so doesn't blow up and the real reason b) fb->obj[0] > already holds a full reference for us. > >

[Xen-devel] [PATCH 6/8] drm/xen: Simplify fb_create

2019-11-15 Thread Daniel Vetter
The current code is a pretty good wtf moment, since we drop the reference before we use it. It's not a big deal, because a) we only use the pointer, so doesn't blow up and the real reason b) fb->obj[0] already holds a full reference for us. Might as well take the real pointer ins't of complicated