[Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-07 Thread Wei Liu
While at it, remove declaration of vcpu_hvm_context and use the proper header. Signed-off-by: Wei Liu --- xen/include/asm-x86/domain.h | 3 --- xen/include/asm-x86/hvm/domain.h | 17 + 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/xen/include/asm-x86/domain

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-07 Thread Jan Beulich
>>> On 07.08.18 at 12:00, wrote: > --- a/xen/include/asm-x86/hvm/domain.h > +++ b/xen/include/asm-x86/hvm/domain.h > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include Why? struct vcpu_hvm_context only needs a forward declaration, just like was the case originally. Full structu

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-07 Thread Wei Liu
On Tue, Aug 07, 2018 at 05:46:06AM -0600, Jan Beulich wrote: > >>> On 07.08.18 at 12:00, wrote: > > --- a/xen/include/asm-x86/hvm/domain.h > > +++ b/xen/include/asm-x86/hvm/domain.h > > @@ -34,6 +34,7 @@ > > #include > > #include > > #include > > +#include > > Why? struct vcpu_hvm_context

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-16 Thread Wei Liu
On Tue, Aug 07, 2018 at 05:24:15PM +0100, Wei Liu wrote: > > > All uses sit either in HVM-specific code or inside is_hvm_...() > > conditionals: Why do we need the inline stub? If the declaration > > was visible independent of CONFIG_HVM, code would compile > > fine, and references to the functio

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 12:42, wrote: > On Tue, Aug 07, 2018 at 05:24:15PM +0100, Wei Liu wrote: > > >> > All uses sit either in HVM-specific code or inside is_hvm_...() >> > conditionals: Why do we need the inline stub? If the declaration >> > was visible independent of CONFIG_HVM, code would compil

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-16 Thread Wei Liu
On Thu, Aug 16, 2018 at 05:24:15AM -0600, Jan Beulich wrote: > >>> On 16.08.18 at 12:42, wrote: > > On Tue, Aug 07, 2018 at 05:24:15PM +0100, Wei Liu wrote: > > > > >> > All uses sit either in HVM-specific code or inside is_hvm_...() > >> > conditionals: Why do we need the inline stub? If the de

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 14:59, wrote: > On Thu, Aug 16, 2018 at 05:24:15AM -0600, Jan Beulich wrote: >> >>> On 16.08.18 at 12:42, wrote: >> > On Tue, Aug 07, 2018 at 05:24:15PM +0100, Wei Liu wrote: >> > > >> >> > All uses sit either in HVM-specific code or inside is_hvm_...() >> >> > conditionals:

Re: [Xen-devel] [PATCH 9/9] x86: move declaration of arch_set_info_hvm_guest and provide stub

2018-08-16 Thread Wei Liu
On Thu, Aug 16, 2018 at 07:48:43AM -0600, Jan Beulich wrote: > >>> On 16.08.18 at 14:59, wrote: > > On Thu, Aug 16, 2018 at 05:24:15AM -0600, Jan Beulich wrote: > >> >>> On 16.08.18 at 12:42, wrote: > >> > On Tue, Aug 07, 2018 at 05:24:15PM +0100, Wei Liu wrote: > >> > > > >> >> > All uses sit