[Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-12 Thread Jan Beulich
In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian emulation") I screwed up quite heavily: Instead of clearing SVI, RVI was cleared. Furthermore, unconditional clearing of SVI is wrong too - other ISR bits should be taken into account. Introduce a new helper set_svi(), split out o

Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-12 Thread Jan Beulich
>>> On 12.10.18 at 11:32, wrote: > In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian > emulation") I screwed up quite heavily: Instead of clearing SVI, RVI was > cleared. I was wrong here: > @@ -2111,14 +2120,13 @@ static bool vmx_test_pir(const struct vc > return pi_test_

Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-18 Thread Tian, Kevin
+Chao to help take a look. > -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, October 12, 2018 5:33 PM > To: xen-devel > Cc: Andrew Cooper ; Wei Liu > ; Nakajima, Jun ; Tian, > Kevin > Subject: [PATCH RFC] VMX: fix vmx_handle_eoi() > > In commit 303066fd

Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-19 Thread Chao Gao
On Fri, Oct 12, 2018 at 03:32:59AM -0600, Jan Beulich wrote: >In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian >emulation") I screwed up quite heavily: Instead of clearing SVI, RVI was >cleared. Furthermore, unconditional clearing of SVI is wrong too - other >ISR bits should be t

Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-25 Thread Jan Beulich
>>> On 19.10.18 at 16:30, wrote: > On Fri, Oct 12, 2018 at 03:32:59AM -0600, Jan Beulich wrote: >>In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian >>emulation") I screwed up quite heavily: Instead of clearing SVI, RVI was >>cleared. Furthermore, unconditional clearing of SVI is

Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-29 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, October 25, 2018 5:46 PM > > >>> On 19.10.18 at 16:30, wrote: > > On Fri, Oct 12, 2018 at 03:32:59AM -0600, Jan Beulich wrote: > >>In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian > >>emulation") I screwed up quit