Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-02-06 Thread Wei Liu
On Tue, Feb 06, 2018 at 05:45:18AM -0700, Jan Beulich wrote: > >>> On 06.02.18 at 13:36, wrote: > > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: > >> - Excluding symlinks in the source tree is a problem for me: Short of > >> out-of-tree builds, in order to easily build test multi

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-02-06 Thread Jan Beulich
>>> On 06.02.18 at 13:36, wrote: > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: >> - Excluding symlinks in the source tree is a problem for me: Short of >> out-of-tree builds, in order to easily build test multiple >> configurations, I'm setting up my build trees as trees of sy

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-02-06 Thread Wei Liu
On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: > There are multiple issues here, and I'm happy to split the patch up if > that's what it takes: > - "set -e" on a separate Makefile line is meaningless. Glue together all > the lines that this is supposed to cover. > - I have no idea w

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-02-01 Thread Roger Pau Monné
On Thu, Feb 01, 2018 at 03:11:28AM -0700, Jan Beulich wrote: > >>> On 01.02.18 at 11:01, wrote: > > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: > >> --- a/tools/firmware/xen-dir/Makefile > >> +++ b/tools/firmware/xen-dir/Makefile > >> @@ -16,18 +16,18 @@ DEP_FILES=$(foreach i, $(L

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-02-01 Thread Jan Beulich
>>> On 01.02.18 at 11:01, wrote: > On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: >> --- a/tools/firmware/xen-dir/Makefile >> +++ b/tools/firmware/xen-dir/Makefile >> @@ -16,18 +16,18 @@ DEP_FILES=$(foreach i, $(LINK_FILES), $( >> >> linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE

Re: [Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-02-01 Thread Roger Pau Monné
On Wed, Jan 31, 2018 at 09:55:21AM -0700, Jan Beulich wrote: > There are multiple issues here, and I'm happy to split the patch up if > that's what it takes: > - "set -e" on a separate Makefile line is meaningless. Glue together all > the lines that this is supposed to cover. > - I have no idea w

[Xen-devel] [PATCH RFC] firmware/shim: fix Xen tree setup

2018-01-31 Thread Jan Beulich
There are multiple issues here, and I'm happy to split the patch up if that's what it takes: - "set -e" on a separate Makefile line is meaningless. Glue together all the lines that this is supposed to cover. - I have no idea what *.d1 is supposed to refer to - we only have .*.d and .*.d2 files