Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-21 Thread Jan Beulich
>>> On 21.08.18 at 12:10, wrote: > On Thu, Aug 16, 2018 at 10:07:00AM +0100, Andrew Cooper wrote: >> Irrespective of what we do here, I'd really like Wei to rebase his work >> to remove the lazy fpu logic from the nested virt paths, because its a >> no-brainer (perf wise) and comes with a massive

Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-21 Thread Wei Liu
On Thu, Aug 16, 2018 at 10:07:00AM +0100, Andrew Cooper wrote: > Irrespective of what we do here, I'd really like Wei to rebase his work > to remove the lazy fpu logic from the nested virt paths, because its a > no-brainer (perf wise) and comes with a massive amount of code > simplification in

Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 13:27, wrote: > On 16/08/18 11:03, Jan Beulich wrote: > On 16.08.18 at 11:07, wrote: >>> On 22/06/2018 11:57, Jan Beulich wrote: --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -616,7 +616,7 @@ void __init init_speculation_mitigations

Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-16 Thread Andrew Cooper
On 16/08/18 11:03, Jan Beulich wrote: On 16.08.18 at 11:07, wrote: >> On 22/06/2018 11:57, Jan Beulich wrote: >>> --- a/xen/arch/x86/spec_ctrl.c >>> +++ b/xen/arch/x86/spec_ctrl.c >>> @@ -616,7 +616,7 @@ void __init init_speculation_mitigations >>> >>> /* Check whether Eager FPU

Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-16 Thread Jan Beulich
>>> On 16.08.18 at 11:07, wrote: > On 22/06/2018 11:57, Jan Beulich wrote: >> --- a/xen/arch/x86/spec_ctrl.c >> +++ b/xen/arch/x86/spec_ctrl.c >> @@ -616,7 +616,7 @@ void __init init_speculation_mitigations >> >> /* Check whether Eager FPU should be enabled by default. */ >> if (

Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-16 Thread Andrew Cooper
On 16/08/2018 10:07, Andrew Cooper wrote: > On 22/06/2018 11:57, Jan Beulich wrote: >> --- a/xen/arch/x86/spec_ctrl.c >> +++ b/xen/arch/x86/spec_ctrl.c >> @@ -616,7 +616,7 @@ void __init init_speculation_mitigations >> >> /* Check whether Eager FPU should be enabled by default. */ >>

Re: [Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-08-16 Thread Andrew Cooper
On 22/06/2018 11:57, Jan Beulich wrote: > --- a/xen/arch/x86/spec_ctrl.c > +++ b/xen/arch/x86/spec_ctrl.c > @@ -616,7 +616,7 @@ void __init init_speculation_mitigations > > /* Check whether Eager FPU should be enabled by default. */ > if ( opt_eager_fpu == -1 ) > -opt_eager_fpu

[Xen-devel] [PATCH RFC] x86/xsave: prefer eager clearing of state over eager restoring

2018-06-22 Thread Jan Beulich
Other than FXRSTOR, XRSTOR allows for setting components to their initial state. Utilize this to clear register state immediately after having saved a vCPU's state (which we don't defer past __context_switch()), considering that - this supposedly reduces power consumption, - this might even free