Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-12-04 Thread Razvan Cojocaru
On 12/4/18 2:54 PM, Jan Beulich wrote: On 04.12.18 at 13:18, wrote: >> Right, so you're saying that the series would be able to go in provided >> that the situation is not made worse than it currently is. > > Well, I'm not the maintainer of this code, so in principle the > series can go in

Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-12-04 Thread Jan Beulich
>>> On 04.12.18 at 13:18, wrote: > Right, so you're saying that the series would be able to go in provided > that the situation is not made worse than it currently is. Well, I'm not the maintainer of this code, so in principle the series can go in despite my reservations. > As far as I can

Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-12-04 Thread Razvan Cojocaru
On 12/3/18 10:49 AM, Jan Beulich wrote: On 30.11.18 at 22:59, wrote: >> On 11/29/18 3:58 PM, Jan Beulich wrote: >>> Altp2m-s don't matter here at all. My point is that the present, >>> unpatched p2m_change_type_range() updates the log-dirty >>> ranges with the unclipped [start,end), but

Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-12-03 Thread Jan Beulich
>>> On 30.11.18 at 22:59, wrote: > On 11/29/18 3:58 PM, Jan Beulich wrote: >> Altp2m-s don't matter here at all. My point is that the present, >> unpatched p2m_change_type_range() updates the log-dirty >> ranges with the unclipped [start,end), but calls >> p2m->change_entry_type_range() with a

Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-11-30 Thread Razvan Cojocaru
On 11/29/18 3:58 PM, Jan Beulich wrote: On 29.11.18 at 14:23, wrote: >> On 11/29/18 12:04 PM, Jan Beulich wrote: >> On 28.11.18 at 22:56, wrote: Changes since V9: - Removed the patch RFC (replaced by a printk(XENLOG_G_WARNING). - Reused start and end in

Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-11-29 Thread Jan Beulich
>>> On 29.11.18 at 14:23, wrote: > On 11/29/18 12:04 PM, Jan Beulich wrote: > On 28.11.18 at 22:56, wrote: >>> Changes since V9: >>> - Removed the patch RFC (replaced by a printk(XENLOG_G_WARNING). >>> - Reused start and end in change_type_range() and removed the >>>intermediary

[Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-11-29 Thread Razvan Cojocaru
On 11/29/18 12:04 PM, Jan Beulich wrote: On 28.11.18 at 22:56, wrote: >> Changes since V9: >> - Removed the patch RFC (replaced by a printk(XENLOG_G_WARNING). >> - Reused start and end in change_type_range() and removed the >>intermediary variables range_start and range_end. >> -

Re: [Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-11-29 Thread Jan Beulich
>>> On 28.11.18 at 22:56, wrote: > Changes since V9: > - Removed the patch RFC (replaced by a printk(XENLOG_G_WARNING). > - Reused start and end in change_type_range() and removed the >intermediary variables range_start and range_end. > - Added an extra explanation for the if ( start > end

[Xen-devel] [PATCH V10 4/5] p2m: Always use hostp2m when clipping rangesets

2018-11-28 Thread Razvan Cojocaru
The logdirty rangesets of the altp2ms need to be kept in sync with the hostp2m. This means when iterating through the altp2ms, we need to use the host p2m to clip the rangeset, not the indiviual altp2m's value. This change also: - Documents that the end is non-inclusive - Calculates an