[Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-21 Thread Peng Fan
The end should be GICD_ISACTIVERN not GICD_ISACTIVER, and also print a warning for the unhandled read. Signed-off-by: Peng Fan --- V2: Add a warning message xen/arch/arm/vgic-v3.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgi

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-22 Thread Stefano Stabellini
On Fri, 22 Nov 2019, Peng Fan wrote: > The end should be GICD_ISACTIVERN not GICD_ISACTIVER, > and also print a warning for the unhandled read. > > Signed-off-by: Peng Fan > --- > > V2: > Add a warning message > > xen/arch/arm/vgic-v3.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-26 Thread Stefano Stabellini
+ Juergen I missed that you weren't in CC to the original patch, sorry. I think this patch should go in, as otherwise Linux 5.4 could run into problems. It is also a pretty straightforward 4 lines patch. On Fri, 22 Nov 2019, Stefano Stabellini wrote: > On Fri, 22 Nov 2019, Peng Fan wrote: > > T

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-26 Thread Julien Grall
Hi, On 26/11/2019 20:43, Stefano Stabellini wrote: + Juergen I missed that you weren't in CC to the original patch, sorry. I think this patch should go in, as otherwise Linux 5.4 could run into problems. It is also a pretty straightforward 4 lines patch. 5.5 (or 5.6) is not going to run on Xe

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-26 Thread Stefano Stabellini
On Tue, 26 Nov 2019, Julien Grall wrote: > Hi, > > On 26/11/2019 20:43, Stefano Stabellini wrote: > > + Juergen > > > > I missed that you weren't in CC to the original patch, sorry. > > I think this patch should go in, as otherwise Linux 5.4 could run into > > problems. It is also a pretty straig

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-26 Thread Julien Grall
Hi, On 26/11/2019 23:17, Stefano Stabellini wrote: On Tue, 26 Nov 2019, Julien Grall wrote: Hi, On 26/11/2019 20:43, Stefano Stabellini wrote: + Juergen I missed that you weren't in CC to the original patch, sorry. I think this patch should go in, as otherwise Linux 5.4 could run into proble

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-26 Thread Jürgen Groß
On 27.11.19 01:01, Julien Grall wrote: Hi, On 26/11/2019 23:17, Stefano Stabellini wrote: On Tue, 26 Nov 2019, Julien Grall wrote: Hi, On 26/11/2019 20:43, Stefano Stabellini wrote: + Juergen I missed that you weren't in CC to the original patch, sorry. I think this patch should go in, as o

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-27 Thread Peng Fan
> Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER > range > > On 27.11.19 01:01, Julien Grall wrote: > > Hi, > > > > On 26/11/2019 23:17, Stefano Stabellini wrote: > >> On Tue, 26 Nov 2019, Julien Grall wrote: > >&g

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-27 Thread Jürgen Groß
On 27.11.19 10:31, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 01:01, Julien Grall wrote: Hi, On 26/11/2019 23:17, Stefano Stabellini wrote: On Tue, 26 Nov 2019, Julien Grall wrote: Hi, On 26/11/2019 20:43, Stefano Stabellini

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-27 Thread Peng Fan
> Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER > range > > On 27.11.19 10:31, Peng Fan wrote: > >> Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix > >> GICD_ISACTIVER range > >> > >> On 27.11.19 01:01, Ju

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-27 Thread Julien Grall
On 27/11/2019 09:49, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 10:31, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 01:01, Julien Grall wrote: Hi, On 26/11

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-27 Thread Stefano Stabellini
On Wed, 27 Nov 2019, Jürgen Groß wrote: > On 27.11.19 10:31, Peng Fan wrote: > > > Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER > > > range > > > > > > On 27.11.19 01:01, Julien Grall wrote: > > > > Hi, > > &

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
Hi Stefano, On 28/11/2019 01:12, Stefano Stabellini wrote: On Wed, 27 Nov 2019, Jürgen Groß wrote: On 27.11.19 10:31, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 01:01, Julien Grall wrote: Hi, On 26/11/2019 23:17, Stefano

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Jürgen Groß
On 28.11.19 09:14, Julien Grall wrote: Hi Stefano, On 28/11/2019 01:12, Stefano Stabellini wrote: On Wed, 27 Nov 2019, Jürgen Groß wrote: On 27.11.19 10:31, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 01:01, Julien Grall

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Peng Fan
> Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER > range > > Hi Stefano, > > On 28/11/2019 01:12, Stefano Stabellini wrote: > > On Wed, 27 Nov 2019, Jürgen Groß wrote: > >> On 27.11.19 10:31, Peng Fan wrote: > >>>> Sub

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
Hi, On 28/11/2019 08:32, Jürgen Groß wrote: On 28.11.19 09:14, Julien Grall wrote: In short, I think the patch should go in now and there are no downsides to it. That's it, I rest my case. Julien, I hope you'll reconsider. I don't really see the point to try to allow Linux 5.4 booting on Xen 4

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Jürgen Groß
On 28.11.19 09:48, Julien Grall wrote: Hi, On 28/11/2019 08:32, Jürgen Groß wrote: On 28.11.19 09:14, Julien Grall wrote: In short, I think the patch should go in now and there are no downsides to it. That's it, I rest my case. Julien, I hope you'll reconsider. I don't really see the point to

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
On 28/11/2019 09:00, Jürgen Groß wrote: On 28.11.19 09:48, Julien Grall wrote: Hi, On 28/11/2019 08:32, Jürgen Groß wrote: On 28.11.19 09:14, Julien Grall wrote: In short, I think the patch should go in now and there are no downsides to it. That's it, I rest my case. Julien, I hope you'll

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Stefano Stabellini
On Thu, 28 Nov 2019, Julien Grall wrote: > > In both cases I see no reason to keep wrong code. > > > > Either the patch will let run Linux 5.4 fine - then the patch should > > definitely be taken. > That's up to Stefano and Peng to provide me information why this is fine. > FAOD, the current justi

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
On Thu, 28 Nov 2019, 18:09 Stefano Stabellini, wrote: > On Thu, 28 Nov 2019, Julien Grall wrote: > > > In both cases I see no reason to keep wrong code. > > > > > > Either the patch will let run Linux 5.4 fine - then the patch should > > > definitely be taken. > > That's up to Stefano and Peng to