Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-28 Thread Razvan Cojocaru
On 9/28/18 12:04 PM, Wei Liu wrote: > On Wed, Sep 26, 2018 at 03:26:20PM +0300, Razvan Cojocaru wrote: >> but is it OK that the hypervisor builds with a set of flags that >> includes CONFIG_HVM and the firmware code with a set that doesn't? > > To answer this question: yes, it is OK to do that. An

Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-28 Thread Wei Liu
On Wed, Sep 26, 2018 at 03:26:20PM +0300, Razvan Cojocaru wrote: > but is it OK that the hypervisor builds with a set of flags that > includes CONFIG_HVM and the firmware code with a set that doesn't? To answer this question: yes, it is OK to do that. And that's deliberate for the shim because it

Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Razvan Cojocaru
On 9/26/18 4:39 PM, Jan Beulich wrote: On 26.09.18 at 15:27, wrote: >> On 9/26/18 4:20 PM, Jan Beulich wrote: >> On 26.09.18 at 14:26, wrote: To clarify the question, I'll of course do this: diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c inde

Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Jan Beulich
>>> On 26.09.18 at 15:27, wrote: > On 9/26/18 4:20 PM, Jan Beulich wrote: > On 26.09.18 at 14:26, wrote: >>> To clarify the question, I'll of course do this: >>> >>> diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c >>> index 67b4a1d..2b5a621 100644 >>> --- a/xen/arch/x

Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Razvan Cojocaru
On 9/26/18 4:20 PM, Jan Beulich wrote: On 26.09.18 at 14:26, wrote: >> To clarify the question, I'll of course do this: >> >> diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c >> index 67b4a1d..2b5a621 100644 >> --- a/xen/arch/x86/mm/mem_access.c >> +++ b/xen/arch/x86/m

Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Jan Beulich
>>> On 26.09.18 at 14:26, wrote: > To clarify the question, I'll of course do this: > > diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c > index 67b4a1d..2b5a621 100644 > --- a/xen/arch/x86/mm/mem_access.c > +++ b/xen/arch/x86/mm/mem_access.c > @@ -489,14 +489,13 @@ long p

Re: [Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Razvan Cojocaru
On 9/26/18 2:39 PM, Razvan Cojocaru wrote: > On 9/26/18 10:34 AM, Razvan Cojocaru wrote: >> Currently there is a subop for setting the memaccess of a page, but not >> for consulting it. The new HVMOP_altp2m_get_mem_access adds this >> functionality. >> >> Both altp2m get/set mem access functions u

[Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Razvan Cojocaru
On 9/26/18 10:34 AM, Razvan Cojocaru wrote: > Currently there is a subop for setting the memaccess of a page, but not > for consulting it. The new HVMOP_altp2m_get_mem_access adds this > functionality. > > Both altp2m get/set mem access functions use the struct > xen_hvm_altp2m_mem_access which h

[Xen-devel] [PATCH V5] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-09-26 Thread Razvan Cojocaru
Currently there is a subop for setting the memaccess of a page, but not for consulting it. The new HVMOP_altp2m_get_mem_access adds this functionality. Both altp2m get/set mem access functions use the struct xen_hvm_altp2m_mem_access which has now dropped the `set' part and has been renamed from