[Xen-devel] [PATCH for-4.12] x86: Improve the efficiency of domain_relinquish_resources()

2019-02-21 Thread Andrew Cooper
pci_release_devices() takes the global PCI lock. Once pci_release_devices() has completed, it will be called redundantly each time paging_teardown() and vcpu_destroy_pagetables() continue. This is liable to be millions of times for a reasonably sized guest, and is a serialising bottleneck now tha

Re: [Xen-devel] [PATCH for-4.12] x86: Improve the efficiency of domain_relinquish_resources()

2019-02-21 Thread Juergen Gross
On 21/02/2019 13:22, Andrew Cooper wrote: > pci_release_devices() takes the global PCI lock. Once pci_release_devices() > has completed, it will be called redundantly each time paging_teardown() and > vcpu_destroy_pagetables() continue. > > This is liable to be millions of times for a reasonably

Re: [Xen-devel] [PATCH for-4.12] x86: Improve the efficiency of domain_relinquish_resources()

2019-02-21 Thread Wei Liu
On Thu, Feb 21, 2019 at 12:22:13PM +, Andrew Cooper wrote: > pci_release_devices() takes the global PCI lock. Once pci_release_devices() > has completed, it will be called redundantly each time paging_teardown() and > vcpu_destroy_pagetables() continue. > > This is liable to be millions of ti

Re: [Xen-devel] [PATCH for-4.12] x86: Improve the efficiency of domain_relinquish_resources()

2019-02-22 Thread Jan Beulich
>>> On 21.02.19 at 14:31, wrote: > On Thu, Feb 21, 2019 at 12:22:13PM +, Andrew Cooper wrote: >> pci_release_devices() takes the global PCI lock. Once pci_release_devices() >> has completed, it will be called redundantly each time paging_teardown() and >> vcpu_destroy_pagetables() continue. >

Re: [Xen-devel] [PATCH for-4.12] x86: Improve the efficiency of domain_relinquish_resources()

2019-02-27 Thread Julien Grall
Hi Andrew, On 2/21/19 12:22 PM, Andrew Cooper wrote: pci_release_devices() takes the global PCI lock. Once pci_release_devices() has completed, it will be called redundantly each time paging_teardown() and vcpu_destroy_pagetables() continue. This is liable to be millions of times for a reasona