Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-11 Thread Jan Beulich
>>> On 11.02.19 at 13:03, wrote: > On Mon, Feb 11, 2019 at 02:47:48AM -0700, Jan Beulich wrote: >> >>> On 08.02.19 at 18:49, wrote: >> > On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: >> >> On 2/5/19 1:38 PM, Roger Pau Monné wrote: >> >> > On Tue, Feb 05, 2019 at 05:44:14AM -0700,

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-11 Thread Roger Pau Monné
On Mon, Feb 11, 2019 at 02:47:48AM -0700, Jan Beulich wrote: > >>> On 08.02.19 at 18:49, wrote: > > On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: > >> On 2/5/19 1:38 PM, Roger Pau Monné wrote: > >> > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: > >> >> When the ass

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-11 Thread Jan Beulich
>>> On 08.02.19 at 18:49, wrote: > On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: >> On 2/5/19 1:38 PM, Roger Pau Monné wrote: >> > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: >> >> When the assertion was introduced, MMIO wasn't handled by the >> >> code correctly

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-08 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 05:21:28PM +, George Dunlap wrote: > On 2/5/19 1:38 PM, Roger Pau Monné wrote: > > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: > > On 05.02.19 at 11:40, wrote: > >>> On Tue, Feb 05, 2019 at 12:45:56AM -0700, Jan Beulich wrote: > >>> On 04.02.19

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-07 Thread George Dunlap
On 2/5/19 1:38 PM, Roger Pau Monné wrote: > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: > On 05.02.19 at 11:40, wrote: >>> On Tue, Feb 05, 2019 at 12:45:56AM -0700, Jan Beulich wrote: >>> On 04.02.19 at 18:18, wrote: > On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beu

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-05 Thread Jan Beulich
>>> On 05.02.19 at 14:38, wrote: > On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: >> >>> On 05.02.19 at 11:40, wrote: >> > On Tue, Feb 05, 2019 at 12:45:56AM -0700, Jan Beulich wrote: >> >> >>> On 04.02.19 at 18:18, wrote: >> >> > On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beuli

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-05 Thread Roger Pau Monné
On Tue, Feb 05, 2019 at 05:44:14AM -0700, Jan Beulich wrote: > >>> On 05.02.19 at 11:40, wrote: > > On Tue, Feb 05, 2019 at 12:45:56AM -0700, Jan Beulich wrote: > >> >>> On 04.02.19 at 18:18, wrote: > >> > On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beulich wrote: > >> >> >>> On 30.01.19 at 11:

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-05 Thread Jan Beulich
>>> On 05.02.19 at 11:40, wrote: > On Tue, Feb 05, 2019 at 12:45:56AM -0700, Jan Beulich wrote: >> >>> On 04.02.19 at 18:18, wrote: >> > On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beulich wrote: >> >> >>> On 30.01.19 at 11:36, wrote: >> >> > The assert was originally added to make sure that h

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-05 Thread Roger Pau Monné
On Tue, Feb 05, 2019 at 12:45:56AM -0700, Jan Beulich wrote: > >>> On 04.02.19 at 18:18, wrote: > > On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beulich wrote: > >> >>> On 30.01.19 at 11:36, wrote: > >> > The assert was originally added to make sure that higher order > >> > regions (> PAGE_ORDER

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-04 Thread Jan Beulich
>>> On 04.02.19 at 18:18, wrote: > On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beulich wrote: >> >>> On 30.01.19 at 11:36, wrote: >> > The assert was originally added to make sure that higher order >> > regions (> PAGE_ORDER_4K) could not be used to bypass the >> > mmio_ro_ranges check performe

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-04 Thread Roger Pau Monné
On Mon, Feb 04, 2019 at 09:56:22AM -0700, Jan Beulich wrote: > >>> On 30.01.19 at 11:36, wrote: > > The assert was originally added to make sure that higher order > > regions (> PAGE_ORDER_4K) could not be used to bypass the > > mmio_ro_ranges check performed by p2m_type_to_flags. > > > > This ho

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-04 Thread Jan Beulich
>>> On 30.01.19 at 11:36, wrote: > The assert was originally added to make sure that higher order > regions (> PAGE_ORDER_4K) could not be used to bypass the > mmio_ro_ranges check performed by p2m_type_to_flags. > > This however is already checked in set_mmio_p2m_entry, which makes > sure that h

Re: [Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-02-04 Thread Andrew Cooper
On 30/01/2019 10:36, Roger Pau Monne wrote: Subject s/ntp/npt/ ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH for-4.12 2/8] amd/ntp: remove assert that prevents creating 2M MMIO entries

2019-01-30 Thread Roger Pau Monne
The assert was originally added to make sure that higher order regions (> PAGE_ORDER_4K) could not be used to bypass the mmio_ro_ranges check performed by p2m_type_to_flags. This however is already checked in set_mmio_p2m_entry, which makes sure that higher order mappings don't overlap with mmio_r