Re: [Xen-devel] [PATCH v1] tools/firmware: reproducible seabios build

2018-07-18 Thread Wei Liu
On Wed, Jul 18, 2018 at 11:58:21AM +0200, Olaf Hering wrote: > Am Wed, 18 Jul 2018 10:39:31 +0100 > schrieb Wei Liu : > > > > + rm -f seabios-dir/.version > > There is no need to rm -f here because the following > will clear its > > content anyway. > > > The content of seabios-dir is coming fr

Re: [Xen-devel] [PATCH v1] tools/firmware: reproducible seabios build

2018-07-18 Thread Olaf Hering
Am Wed, 18 Jul 2018 10:39:31 +0100 schrieb Wei Liu : > > + rm -f seabios-dir/.version > There is no need to rm -f here because the following > will clear its > content anyway. The content of seabios-dir is coming from upstream, ".version" might be a symlink. Thats why I added this rm comman

Re: [Xen-devel] [PATCH v1] tools/firmware: reproducible seabios build

2018-07-18 Thread Wei Liu
On Fri, Jul 13, 2018 at 01:04:42PM +0200, Olaf Hering wrote: > The buildsystem of seabios always includes the current time and the > hostname into the resulting binary. To avoid that, it is required to > have a file '.version' in the toplevel directory of seabios-dir-remote. > And it is required to

[Xen-devel] [PATCH v1] tools/firmware: reproducible seabios build

2018-07-13 Thread Olaf Hering
The buildsystem of seabios always includes the current time and the hostname into the resulting binary. To avoid that, it is required to have a file '.version' in the toplevel directory of seabios-dir-remote. And it is required to pass EXTRAVERSION= to make because its toplevel Makefile does not ta