[Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-11-28 Thread Paul Durrant
...to allow the calling domain to prevent translation of specified l1e value. Despite what the comment in public/xen.h might imply, specifying a command value of MMU_NORMAL_PT_UPDATE will not simply update an l1e with the specified value. Instead, mod_l1_entry() tests whether foreign_dom has PG_tr

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-12 Thread Jan Beulich
>>> On 28.11.17 at 16:08, wrote: > @@ -1905,7 +1906,8 @@ static int mod_l1_entry(l1_pgentry_t *pl1e, > l1_pgentry_t nl1e, > } > > /* Translate foreign guest address. */ > -if ( paging_mode_translate(pg_dom) ) > +if ( cmd != MMU_PT_UPDATE_NO_TRANSLATE && > +

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-12 Thread Andrew Cooper
On 12/12/17 13:25, Jan Beulich wrote: On 28.11.17 at 16:08, wrote: >> @@ -1905,7 +1906,8 @@ static int mod_l1_entry(l1_pgentry_t *pl1e, >> l1_pgentry_t nl1e, >> } >> >> /* Translate foreign guest address. */ >> -if ( paging_mode_translate(pg_dom) ) >> +if

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-12 Thread Jan Beulich
>>> On 12.12.17 at 14:52, wrote: > On 12/12/17 13:25, Jan Beulich wrote: > On 28.11.17 at 16:08, wrote: >>> @@ -1905,7 +1906,8 @@ static int mod_l1_entry(l1_pgentry_t *pl1e, > l1_pgentry_t nl1e, >>> } >>> >>> /* Translate foreign guest address. */ >>> -if ( paging

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 December 2017 13:25 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel@lists.xenproject.org; Tim (Xen.org) > > Subject: Re: [PATCH v14 07/11] x

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-13 Thread Paul Durrant
-Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 December 2017 14:39 > To: Andrew Cooper > Cc: Paul Durrant ; Wei Liu ; > George Dunlap ; Ian Jackson > ; Stefano Stabellini ; xen- > de...@lists.xenproject.org; Tim (Xen.org) > Subject: Re: [PATCH v14 07/11] x86

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-13 Thread Jan Beulich
>>> On 13.12.17 at 13:06, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 December 2017 14:39 >> >>> On 12.12.17 at 14:52, wrote: >> > We are deliberately trying to introducing a mechanism whereby a >> > toolstack/device-mode/other semi-privileged entity can map resources >> >

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 December 2017 14:36 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Stefano Stabellini ; xen- > de...@lists.xenproject.org; Tim (Xen.org) > Subject: RE: [PATCH v14 07/11] x8

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-13 Thread Jan Beulich
>>> On 13.12.17 at 15:49, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 December 2017 14:36 >> >>> On 13.12.17 at 13:06, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: 12 December 2017 14:39 >> >> >>> On 12.12.17 at 14:52, wrote: >> >> > We are delibe

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 December 2017 15:25 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Stefano Stabellini ; xen- > de...@lists.xenproject.org; Tim (Xen.org) > Subject: RE: [PATCH v14 07/11] x8

Re: [Xen-devel] [PATCH v14 07/11] x86/mm: add an extra command to HYPERVISOR_mmu_update...

2017-12-14 Thread Jan Beulich
>>> On 13.12.17 at 18:03, wrote: > Looking through the code, the only one thing that bothers me is the > page_set_owner() done in shadow_enable() for the page used for HVM guest > vcpus that have paging disabled. AFAICT that page would become mappable by an > emulating domain with MMU_PT_UPDATE