Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-31 Thread Paul Durrant
rge > Dunlap ; Tim (Xen.org) ; Julien > Grall ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order > parameter to iommu_map/unmap_page() > > On Mon, Oct 29, 2018 at 01:29:28PM +, Paul Durrant wrote: > > The P2M code currently contains many

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 October 2018 17:05 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap ; Ian > Jackson ; Wei Liu ; Jun > Nakajima ; Kevin Tian ; > Stefano Stabellini ; xen-devel

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:56, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 October 2018 16:08 >> >> >>> On 29.10.18 at 14:29, wrote: >> > --- a/xen/common/grant_table.c >> > +++ b/xen/common/grant_table.c >> > @@ -1142,12 +1142,14 @@ map_grant_ref( >> > { >> >

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 October 2018 16:08 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap ; Wei > Liu ; Ian Jackson ; Jun > Nakajima ; Kevin Tian ; > Stefano Stabellini ; xen-devel

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 14:29, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -1142,12 +1142,14 @@ map_grant_ref( > { > if ( !(kind & MAPKIND_WRITE) ) > err = iommu_map_page(ld, _dfn(mfn_x(mfn)), mfn, > +

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 01:29:28PM +, Paul Durrant wrote: > The P2M code currently contains many loops to deal with the fact that, > while it may be require to handle page orders greater than 4k, the > IOMMU map and unmap functions do not. > This patch adds a page_order parameter to those

[Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-29 Thread Paul Durrant
The P2M code currently contains many loops to deal with the fact that, while it may be require to handle page orders greater than 4k, the IOMMU map and unmap functions do not. This patch adds a page_order parameter to those functions and implements the necessary loops within. This allows the P2M