Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Andrew Cooper
On 06/02/2020 12:57, Jan Beulich wrote: > On 06.02.2020 12:44, Durrant, Paul wrote: >>> -Original Message- >>> From: Julien Grall >>> Sent: 06 February 2020 11:17 >>> To: Durrant, Paul ; xen-devel@lists.xenproject.org >>> Cc: Grall, Julien >>> Subject: Re: [PATCH v2] xen/mm: Avoid

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Jan Beulich
On 06.02.2020 11:38, Julien Grall wrote: > However, the code may race with the page offlining code (see > offline_page()). Depending on the ordering, the page may be in offlining > state (PGC_state_offlining) before it is assigned to a domain. > > On debug build, this may result to hit the assert

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Jan Beulich
On 06.02.2020 12:44, Durrant, Paul wrote: >> -Original Message- >> From: Julien Grall >> Sent: 06 February 2020 11:17 >> To: Durrant, Paul ; xen-devel@lists.xenproject.org >> Cc: Grall, Julien >> Subject: Re: [PATCH v2] xen/mm: Avoid assuming the page is inuse in >> assign_pages() >> >>

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 06 February 2020 11:17 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Grall, Julien > Subject: Re: [PATCH v2] xen/mm: Avoid assuming the page is inuse in > assign_pages() > > Hi Paul, > > On 06/02/2020 10:52, Durrant, Paul

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Julien Grall
Hi Paul, On 06/02/2020 10:52, Durrant, Paul wrote: -Original Message- From: Julien Grall Sent: 06 February 2020 10:39 To: xen-devel@lists.xenproject.org Cc: jul...@xen.org; Durrant, Paul ; Grall, Julien Subject: [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 06 February 2020 10:39 > To: xen-devel@lists.xenproject.org > Cc: jul...@xen.org; Durrant, Paul ; Grall, Julien > > Subject: [PATCH v2] xen/mm: Avoid assuming the page is inuse in > assign_pages() > > From: Julien Grall > > At the

[Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Julien Grall
From: Julien Grall At the moment, assign_pages() on the page to be inuse (PGC_state_inuse) and the state value to be 0. However, the code may race with the page offlining code (see offline_page()). Depending on the ordering, the page may be in offlining state (PGC_state_offlining) before it is