[Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-13 Thread Andrew Cooper
... rather than setting the limits up after domain_create() has completed. This removes all the gnttab infrastructure for calculating the number of dom0 grant frames, opting instead to require the dom0 construction code to pass a sane value in via the configuration. In practice, this now means th

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-14 Thread Roger Pau Monné
On Mon, Aug 13, 2018 at 11:01:03AM +0100, Andrew Cooper wrote: > ... rather than setting the limits up after domain_create() has completed. > > This removes all the gnttab infrastructure for calculating the number of dom0 > grant frames, opting instead to require the dom0 construction code to pass

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-15 Thread Jan Beulich
>>> On 13.08.18 at 12:01, wrote: > ... rather than setting the limits up after domain_create() has completed. > > This removes all the gnttab infrastructure for calculating the number of dom0 > grant frames, opting instead to require the dom0 construction code to pass a > sane value in via the co

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-15 Thread Julien Grall
Hi Andrew, On 08/13/2018 11:01 AM, Andrew Cooper wrote: ... rather than setting the limits up after domain_create() has completed. This removes all the gnttab infrastructure for calculating the number of dom0 grant frames, opting instead to require the dom0 construction code to pass a sane valu

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-15 Thread Andrew Cooper
On 15/08/18 14:04, Julien Grall wrote: > Hi Andrew, > > On 08/13/2018 11:01 AM, Andrew Cooper wrote: >> ... rather than setting the limits up after domain_create() has >> completed. >> >> This removes all the gnttab infrastructure for calculating the number >> of dom0 >> grant frames, opting instea

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-15 Thread Julien Grall
Hi Andrew, On 08/15/2018 02:08 PM, Andrew Cooper wrote: On 15/08/18 14:04, Julien Grall wrote: Hi Andrew, On 08/13/2018 11:01 AM, Andrew Cooper wrote: ... rather than setting the limits up after domain_create() has completed. This removes all the gnttab infrastructure for calculating the num

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-15 Thread Andrew Cooper
On 15/08/18 14:32, Julien Grall wrote: > Hi Andrew,      #ifdef CONFIG_ARM_32    /* diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 45f3841..3d3b30c 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -20,6 +20,7 @@    #include

Re: [Xen-devel] [PATCH v2 06/12] xen/gnttab: Pass max_{grant, maptrack}_frames into grant_table_create()

2018-08-16 Thread Julien Grall
Hi Andrew, On 08/15/2018 08:03 PM, Andrew Cooper wrote: Actually, I remember now what the problem was.  d->grant_table is an opaque type, so .max_grant_frames can't be accessed. One of my indented bits of cleanup here is to remove the gnttab_dom0_frames() function, because it has no business li