Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC

2018-04-04 Thread André Przywara
On 05/04/18 00:17, Amit Tomer wrote: > Hi, > >> Ah yes, if that works, we should. That bit is from the Linux BSP, isn't it? > > Yes, it's from Linux BSP code only. Hope following is fine. > > if ( reg & STATUS_TXFIFO_EMP ) > return TX_FIFO_SIZE; > else if ( reg &

Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC

2018-04-04 Thread Amit Tomer
Hi, > Ah yes, if that works, we should. That bit is from the Linux BSP, isn't it? Yes, it's from Linux BSP code only. Hope following is fine. if ( reg & STATUS_TXFIFO_EMP ) return TX_FIFO_SIZE; else if ( reg & STAT_TX_FIFO_HFL ) return TX_FIFO_SIZE / 2; else if (

Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC

2018-04-04 Thread André Przywara
On 04/04/18 23:25, Amit Tomer wrote: > Hi, > >> Just a nit, but it might be smarter to first check for the receive IRQ, >> because not handling this might loose information. TX is less critical. > > Ok, actually tried it ealier when I was debugging the Rx path issue and > that time it didn't

Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC

2018-04-04 Thread Amit Tomer
Hi, > Just a nit, but it might be smarter to first check for the receive IRQ, > because not handling this might loose information. TX is less critical. Ok, actually tried it ealier when I was debugging the Rx path issue and that time it didn't work. May be I should try it again. > Similar to

Re: [Xen-devel] [PATCH v2 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC

2018-04-04 Thread Andre Przywara
Hi, On 03/04/18 14:49, Amit Singh Tomar wrote: > This patch adds driver for UART controller found on Armada 3700 SoC. > > There is no reference manuals available for 3700 SoC in public and it > is derived by looking at Linux driver[1]. > >

[Xen-devel] [PATCH v2 1/2] xen/arm: Add MVEBU UART driver for Marvell Armada 3700 SoC

2018-04-03 Thread Amit Singh Tomar
This patch adds driver for UART controller found on Armada 3700 SoC. There is no reference manuals available for 3700 SoC in public and it is derived by looking at Linux driver[1]. [1]https://github.com/torvalds/linux/blob/master/drivers/tty/serial/mvebu-uart.c Signed-off-by: Amit Singh Tomar