Re: [Xen-devel] [PATCH v2 1/3] x86/svm: Simplify svm_get_insn_len()

2018-12-14 Thread Jan Beulich
>>> On 13.12.18 at 21:22, wrote: > @@ -98,13 +97,10 @@ int __get_instruction_length_from_list(struct vcpu *v, > * hardware. > */ > #ifdef NDEBUG > -if ( (inst_len = svm_nextrip_insn_length(v)) > MAX_INST_LEN ) > -gprintk(XENLOG_WARNING, "NRip reported inst_len %lu\n", inst

[Xen-devel] [PATCH v2 1/3] x86/svm: Simplify svm_get_insn_len()

2018-12-13 Thread Andrew Cooper
The existing __get_instruction_length_from_list() has a single user which uses the list functionality. That user however should be looking specifically for INVD or WBINVD, as reported by the vmexit exit reason. Modify svm_vmexit_do_invalidate_cache() to ask for the correct instruction, and drop a