[Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-13 Thread Andrew Cooper
From: Roger Pau Monné Signed-off-by: Sergey Dyasli Signed-off-by: Roger Pau Monné Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Sergey Dyasli CC: Ian Jackson v2: * Rebase over the msr_{domain,vcpu}_policy rename * Only deserialse msr_policy * Exp

Re: [Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-16 Thread Wei Liu
On Fri, Jul 13, 2018 at 09:03:11PM +0100, Andrew Cooper wrote: > From: Roger Pau Monné > > Signed-off-by: Sergey Dyasli > Signed-off-by: Roger Pau Monné > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists

Re: [Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-16 Thread Jan Beulich
>>> On 13.07.18 at 22:03, wrote: > --- a/xen/common/libx86/msr.c > +++ b/xen/common/libx86/msr.c > @@ -45,6 +45,57 @@ int x86_msr_copy_to_buffer(const struct msr_policy *p, > return 0; > } > > +int x86_msr_copy_from_buffer(struct msr_policy *p, > + const msr_ent

Re: [Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-17 Thread Andrew Cooper
On 16/07/18 12:36, Jan Beulich wrote: On 13.07.18 at 22:03, wrote: >> --- a/xen/common/libx86/msr.c >> +++ b/xen/common/libx86/msr.c >> @@ -45,6 +45,57 @@ int x86_msr_copy_to_buffer(const struct msr_policy *p, >> return 0; >> } >> >> +int x86_msr_copy_from_buffer(struct msr_policy *p,

Re: [Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-17 Thread Jan Beulich
>>> On 17.07.18 at 12:17, wrote: > On 16/07/18 12:36, Jan Beulich wrote: > On 13.07.18 at 22:03, wrote: >>> --- a/xen/common/libx86/msr.c >>> +++ b/xen/common/libx86/msr.c >>> @@ -45,6 +45,57 @@ int x86_msr_copy_to_buffer(const struct msr_policy *p, >>> return 0; >>> } >>> >>> +int x8

Re: [Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-17 Thread Andrew Cooper
On 17/07/18 13:01, Jan Beulich wrote: +goto err; + +p->plaform_info.raw = data.val; >>> No other sanity checking? >> Correct. This is a data marshalling function, not an auditing function. >> >> The auditing functions are also needed for in-place modifica

Re: [Xen-devel] [PATCH v2 10/13] libx86: introduce a helper to deserialise msr_policy objects

2018-07-17 Thread Jan Beulich
>>> On 17.07.18 at 18:06, wrote: > On 17/07/18 13:01, Jan Beulich wrote: > +goto err; > + > +p->plaform_info.raw = data.val; No other sanity checking? >>> Correct. This is a data marshalling function, not an auditing function. >>> >>> The auditing func