Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-03-09 Thread Tian, Kevin
> From: Jan Beulich > Sent: Monday, March 9, 2020 4:59 PM > > On 28.02.2020 13:12, Jan Beulich wrote: > > The wider cluster mode APIC IDs aren't generally representable. Convert > > the iommu_intremap variable into a tristate, allowing the AMD IOMMU > > driver to signal this special restriction t

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-03-09 Thread Jan Beulich
On 28.02.2020 13:12, Jan Beulich wrote: > The wider cluster mode APIC IDs aren't generally representable. Convert > the iommu_intremap variable into a tristate, allowing the AMD IOMMU > driver to signal this special restriction to the apic_x2apic_probe(). > (Note: assignments to the variable get ad

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-03-03 Thread Jan Beulich
On 03.03.2020 17:05, Jan Beulich wrote: > On 28.02.2020 13:31, Roger Pau Monné wrote: >> On Fri, Feb 28, 2020 at 01:12:03PM +0100, Jan Beulich wrote: >>> --- a/xen/arch/x86/genapic/x2apic.c >>> +++ b/xen/arch/x86/genapic/x2apic.c >>> @@ -236,12 +236,21 @@ const struct genapic *__init apic_x2apic >>

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-03-03 Thread Jan Beulich
On 28.02.2020 13:31, Roger Pau Monné wrote: > On Fri, Feb 28, 2020 at 01:12:03PM +0100, Jan Beulich wrote: >> --- a/xen/arch/x86/genapic/x2apic.c >> +++ b/xen/arch/x86/genapic/x2apic.c >> @@ -236,12 +236,21 @@ const struct genapic *__init apic_x2apic >> x2apic_phys = !iommu_intremap || >>

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-02-28 Thread Roger Pau Monné
On Fri, Feb 28, 2020 at 01:39:59PM +0100, Jan Beulich wrote: > On 28.02.2020 13:31, Roger Pau Monné wrote: > > On Fri, Feb 28, 2020 at 01:12:03PM +0100, Jan Beulich wrote: > >> --- a/xen/arch/x86/genapic/x2apic.c > >> +++ b/xen/arch/x86/genapic/x2apic.c > >> @@ -236,12 +236,21 @@ const struct genap

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-02-28 Thread Jan Beulich
On 28.02.2020 15:48, Andrew Cooper wrote: > On 28/02/2020 12:12, Jan Beulich wrote: >> The wider cluster mode APIC IDs aren't generally representable. Convert >> the iommu_intremap variable into a tristate, allowing the AMD IOMMU >> driver to signal this special restriction to the apic_x2apic_probe

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-02-28 Thread Andrew Cooper
On 28/02/2020 12:12, Jan Beulich wrote: > The wider cluster mode APIC IDs aren't generally representable. Convert > the iommu_intremap variable into a tristate, allowing the AMD IOMMU > driver to signal this special restriction to the apic_x2apic_probe(). > (Note: assignments to the variable get ad

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-02-28 Thread Jan Beulich
On 28.02.2020 13:31, Roger Pau Monné wrote: > On Fri, Feb 28, 2020 at 01:12:03PM +0100, Jan Beulich wrote: >> --- a/xen/arch/x86/genapic/x2apic.c >> +++ b/xen/arch/x86/genapic/x2apic.c >> @@ -236,12 +236,21 @@ const struct genapic *__init apic_x2apic >> x2apic_phys = !iommu_intremap || >>

Re: [Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-02-28 Thread Roger Pau Monné
On Fri, Feb 28, 2020 at 01:12:03PM +0100, Jan Beulich wrote: > The wider cluster mode APIC IDs aren't generally representable. Convert > the iommu_intremap variable into a tristate, allowing the AMD IOMMU > driver to signal this special restriction to the apic_x2apic_probe(). > (Note: assignments t

[Xen-devel] [PATCH v2 2/2] AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode

2020-02-28 Thread Jan Beulich
The wider cluster mode APIC IDs aren't generally representable. Convert the iommu_intremap variable into a tristate, allowing the AMD IOMMU driver to signal this special restriction to the apic_x2apic_probe(). (Note: assignments to the variable get adjusted, while existing consumers - all assuming