Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-20 Thread Jan Beulich
>>> On 17.08.18 at 20:45, wrote: > On Fri, Aug 17, 2018 at 12:59:28AM -0600, Jan Beulich wrote: >> >>> On 16.08.18 at 22:02, wrote: >> > On Wed, Aug 15, 2018 at 10:00:48AM -0600, Jan Beulich wrote: >> >> > +bool __read_mostly ssbd_amd_smt_en = false; >> >> > +bool __read_mostly

Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-17 Thread Brian Woods
On Fri, Aug 17, 2018 at 12:59:28AM -0600, Jan Beulich wrote: > >>> On 16.08.18 at 22:02, wrote: > > On Wed, Aug 15, 2018 at 10:00:48AM -0600, Jan Beulich wrote: > >> >>> On 09.08.18 at 21:42, wrote: > >> > --- a/xen/arch/x86/spec_ctrl.c > >> > +++ b/xen/arch/x86/spec_ctrl.c > >> > >> First of

Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-17 Thread Jan Beulich
>>> On 16.08.18 at 22:02, wrote: > On Wed, Aug 15, 2018 at 10:00:48AM -0600, Jan Beulich wrote: >> >>> On 09.08.18 at 21:42, wrote: >> > --- a/xen/arch/x86/spec_ctrl.c >> > +++ b/xen/arch/x86/spec_ctrl.c >> >> First of all - I'm not convinced some of the AMD specific code here >> wouldn't

Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-16 Thread Brian Woods
On Wed, Aug 15, 2018 at 10:00:48AM -0600, Jan Beulich wrote: > >>> On 09.08.18 at 21:42, wrote: > > --- a/xen/arch/x86/cpu/amd.c > > +++ b/xen/arch/x86/cpu/amd.c > > @@ -611,14 +611,9 @@ static void init_amd(struct cpuinfo_x86 *c) > > ssbd_amd_ls_cfg_mask = 1ull << bit; > >

Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-15 Thread Jan Beulich
>>> On 09.08.18 at 21:42, wrote: > --- a/xen/arch/x86/cpu/amd.c > +++ b/xen/arch/x86/cpu/amd.c > @@ -611,14 +611,9 @@ static void init_amd(struct cpuinfo_x86 *c) > ssbd_amd_ls_cfg_mask = 1ull << bit; > } > > - if (ssbd_amd_ls_cfg_mask &&

Re: [Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-09 Thread Brian Woods
On Thu, Aug 09, 2018 at 02:42:13PM -0500, Brian Woods wrote: > @@ -237,8 +247,8 @@ static void __init print_details(enum ind_thunk thunk, > uint64_t caps) > - !boot_cpu_has(X86_FEATURE_SSBD_AMD_LS_CFG)? "" : > - (opt_ssbd && ssbd_amd_ls_cfg_mask)? " SSBD+" : " SSBD-",

[Xen-devel] [PATCH v2 2/2] x86/spec-ctrl: add support for modifying SSBD VIA LS_CFG MSR

2018-08-09 Thread Brian Woods
Adds support for modifying the LS_CFG MSR to enable SSBD on supporting AMD CPUs. There needs to be locking logic for family 17h with SMT enabled since both threads share the same MSR. Otherwise, a core just needs to write to the LS_CFG MSR. For more information see: