Re: [Xen-devel] [PATCH v2 3/3] x86/mm: re-order a few conditionals

2020-01-06 Thread Andrew Cooper
On 06/01/2020 15:35, Jan Beulich wrote: > is_{hvm,pv}_*() can be expensive now, so where possible evaluate cheaper > conditions first. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > --- > v2: New. > --- > I couldn't really decide whether to drop the two involved unlikely(). Personall

[Xen-devel] [PATCH v2 3/3] x86/mm: re-order a few conditionals

2020-01-06 Thread Jan Beulich
is_{hvm,pv}_*() can be expensive now, so where possible evaluate cheaper conditions first. Signed-off-by: Jan Beulich --- v2: New. --- I couldn't really decide whether to drop the two involved unlikely(). --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1588,7 +1588,7 @@ static int promote_l3