Re: [Xen-devel] [PATCH v2 3/7] x86: introduce altinstruction_nop assembler macro

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 20:25, wrote: > On 07/02/18 16:13, Jan Beulich wrote: >> This allows shortening (and making more obvious what they do) some >> altinstruction_entry uses. >> >> Signed-off-by: Jan Beulich > > In principle, Reviewed-by: Andrew Cooper , > but I'd prefer if you held it back until

Re: [Xen-devel] [PATCH v2 3/7] x86: introduce altinstruction_nop assembler macro

2018-03-01 Thread Andrew Cooper
On 07/02/18 16:13, Jan Beulich wrote: > This allows shortening (and making more obvious what they do) some > altinstruction_entry uses. > > Signed-off-by: Jan Beulich In principle, Reviewed-by: Andrew Cooper , but I'd prefer if you held it back until my nop calculation series is in, which will dr

[Xen-devel] [PATCH v2 3/7] x86: introduce altinstruction_nop assembler macro

2018-02-07 Thread Jan Beulich
This allows shortening (and making more obvious what they do) some altinstruction_entry uses. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_64/compat/entry.S +++ b/xen/arch/x86/x86_64/compat/entry.S @@ -135,8 +135,7 @@ ENTRY(compat_restore_all_guest) jne 1b .Lcr4_alt_end: