Re: [Xen-devel] [PATCH v2 4/4] xen: use __symbol everywhere

2018-11-06 Thread Stefano Stabellini
On Wed, 17 Oct 2018, Julien Grall wrote: > Hi, > > On 17/10/2018 15:31, Stefano Stabellini wrote: > > Use __symbol everywhere _stext, _etext, etc. are used. Technically, it > > is only required when comparing pointers, but use it everywhere to avoid > > Well no. It is also required when

Re: [Xen-devel] [PATCH v2 4/4] xen: use __symbol everywhere

2018-10-17 Thread Julien Grall
Hi, On 17/10/2018 15:31, Stefano Stabellini wrote: Use __symbol everywhere _stext, _etext, etc. are used. Technically, it is only required when comparing pointers, but use it everywhere to avoid Well no. It is also required when substracting pointers (see [1]). confusion. [...] diff

[Xen-devel] [PATCH v2 4/4] xen: use __symbol everywhere

2018-10-17 Thread Stefano Stabellini
Use __symbol everywhere _stext, _etext, etc. are used. Technically, it is only required when comparing pointers, but use it everywhere to avoid confusion. Signed-off-by: Stefano Stabellini CC: jbeul...@suse.com CC: andrew.coop...@citrix.com --- Changes in v2: - cast return of __symbol to char*