On 27/11/2019, 19:06, "Stefano Stabellini" wrote:
On Fri, 27 Sep 2019, Jan Beulich wrote:
> On 26.09.2019 21:39, Lars Kurth wrote:
> > +### Verbose vs. terse
> > +Due to the time it takes to review and compose code reviewer,
reviewers often adopt a
> > +terse style. It is
On 27/11/2019, 18:57, "Stefano Stabellini" wrote:
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This guide covers the bulk on Best Practice related to code review
> It primarily focusses on code review interactions
> It also covers how to deal with
On Fri, 27 Sep 2019, Jan Beulich wrote:
> On 26.09.2019 21:39, Lars Kurth wrote:
> > +### Verbose vs. terse
> > +Due to the time it takes to review and compose code reviewer, reviewers
> > often adopt a
> > +terse style. It is not unusual to see review comments such as
> > +> typo
> > +>
On Thu, 26 Sep 2019, Lars Kurth wrote:
> From: Lars Kurth
>
> This guide covers the bulk on Best Practice related to code review
> It primarily focusses on code review interactions
> It also covers how to deal with Misunderstandings and Cultural
> Differences
>
> Signed-off-by: Lars Kurth
>
On 07.10.2019 18:13, George Dunlap wrote:
> On 9/27/19 10:14 AM, Jan Beulich wrote:
>> On 26.09.2019 21:39, Lars Kurth wrote:
>>> +### Verbose vs. terse
>>> +Due to the time it takes to review and compose code reviewer, reviewers
>>> often adopt a
>>> +terse style. It is not unusual to see review
On 9/27/19 10:14 AM, Jan Beulich wrote:
> On 26.09.2019 21:39, Lars Kurth wrote:
>> +### Verbose vs. terse
>> +Due to the time it takes to review and compose code reviewer, reviewers
>> often adopt a
>> +terse style. It is not unusual to see review comments such as
>> +> typo
>> +>
On 9/26/19 8:39 PM, Lars Kurth wrote:
> +investigate the practice foot-binding, it is hard to disagree with the
> dictionart entry.
Typo: dictionary
-George
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
On 27.09.2019 12:17, Lars Kurth wrote:
> Can I maybe get you to reconsider and re-review the next version from the
> view point of an author and maybe make suggestions on how to create more
> balance
I'll certainly make an attempt.
Jan
___
Xen-devel
On 27/09/2019, 11:17, "Lars Kurth" wrote:
On 27/09/2019, 10:14, "Jan Beulich" wrote:
On 26.09.2019 21:39, Lars Kurth wrote:
> +### Verbose vs. terse
> +Due to the time it takes to review and compose code reviewer,
reviewers often adopt a
>
On 27/09/2019, 10:14, "Jan Beulich" wrote:
On 26.09.2019 21:39, Lars Kurth wrote:
> +### Verbose vs. terse
> +Due to the time it takes to review and compose code reviewer, reviewers
often adopt a
> +terse style. It is not unusual to see review comments such as
> +> typo
On 27/09/2019, 09:59, "Jan Beulich" wrote:
On 26.09.2019 21:39, Lars Kurth wrote:
> +### Express appreciation
> +As the nature of code review to find bugs and possible issues, it is
very easy for
> +reviewers to get into a mode of operation where the patch review ends up
On 26.09.2019 21:39, Lars Kurth wrote:
> +### Verbose vs. terse
> +Due to the time it takes to review and compose code reviewer, reviewers
> often adopt a
> +terse style. It is not unusual to see review comments such as
> +> typo
> +> s/resions/regions/
> +> coding style
> +> coding style:
On 26.09.2019 21:39, Lars Kurth wrote:
> +### Express appreciation
> +As the nature of code review to find bugs and possible issues, it is very
> easy for
> +reviewers to get into a mode of operation where the patch review ends up
> being a list
> +of issues, not mentioning what is right and
From: Lars Kurth
This guide covers the bulk on Best Practice related to code review
It primarily focusses on code review interactions
It also covers how to deal with Misunderstandings and Cultural
Differences
Signed-off-by: Lars Kurth
---
Cc: minios-de...@lists.xenproject.org
Cc:
14 matches
Mail list logo
