Re: [Xen-devel] [PATCH v2 5/6] tools/libx[cl]: Don't use HVM_PARAM_PAE_ENABLED as a function parameter

2020-02-17 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v2 5/6] tools/libx[cl]: Don't use HVM_PARAM_PAE_ENABLED as a function parameter"): > HVM_PARAM_PAE_ENABLED is set and consumed by the toolstack only. It is in > practice a complicated and non-standard way of passing a boolean parameter > into

[Xen-devel] [PATCH v2 5/6] tools/libx[cl]: Don't use HVM_PARAM_PAE_ENABLED as a function parameter

2020-02-17 Thread Andrew Cooper
HVM_PARAM_PAE_ENABLED is set and consumed by the toolstack only. It is in practice a complicated and non-standard way of passing a boolean parameter into xc_cpuid_apply_policy(). This is silly. Pass PAE as a regular parameter instead. In libxl__cpuid_legacy(), leave a rather better