Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-05 Thread Jan Beulich
>>> On 02.03.18 at 20:34, wrote: > On 02/03/18 07:10, Jan Beulich wrote: > On 01.03.18 at 17:58, wrote: >>> The pont of having the toolchain put out optimised nops is to avoid the >>> need for us to patch the site at all. I.e. calling optimise_nops() on a >>> set of toolchain nops defeats th

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-02 Thread Andrew Cooper
On 02/03/18 07:10, Jan Beulich wrote: On 01.03.18 at 17:58, wrote: >> On 01/03/18 10:54, Jan Beulich wrote: >> On 01.03.18 at 11:36, wrote: On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: Andrew Cooper 02/28/18 7:20 PM >>> >> On 28/02/18 16:22, Jan Beulich

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 17:58, wrote: > On 01/03/18 10:54, Jan Beulich wrote: > On 01.03.18 at 11:36, wrote: >>> On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >>> Andrew Cooper 02/28/18 7:20 PM >>> > On 28/02/18 16:22, Jan Beulich wrote: > On 26.02.18 at 12:35, wro

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-01 Thread Andrew Cooper
On 01/03/18 10:54, Jan Beulich wrote: On 01.03.18 at 11:36, wrote: >> On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >> Andrew Cooper 02/28/18 7:20 PM >>> On 28/02/18 16:22, Jan Beulich wrote: On 26.02.18 at 12:35, wrote: >> --- a/xen/include/asm-x86/alte

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 11:36, wrote: > On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >> >>> Andrew Cooper 02/28/18 7:20 PM >>> >> >On 28/02/18 16:22, Jan Beulich wrote: >> > On 26.02.18 at 12:35, wrote: >> >>> --- a/xen/include/asm-x86/alternative-asm.h >> >>> +++ b/xen/include/as

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-01 Thread Roger Pau Monné
On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: > >>> Andrew Cooper 02/28/18 7:20 PM >>> > >On 28/02/18 16:22, Jan Beulich wrote: > > On 26.02.18 at 12:35, wrote: > >>> --- a/xen/include/asm-x86/alternative-asm.h > >>> +++ b/xen/include/asm-x86/alternative-asm.h > >>> @@ -1,6 +1,

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-28 Thread Jan Beulich
>>> Andrew Cooper 02/28/18 7:20 PM >>> >On 28/02/18 16:22, Jan Beulich wrote: > On 26.02.18 at 12:35, wrote: >>> --- a/xen/include/asm-x86/alternative-asm.h >>> +++ b/xen/include/asm-x86/alternative-asm.h >>> @@ -1,6 +1,8 @@ >>> #ifndef _ASM_X86_ALTERNATIVE_ASM_H_ >>> #define _ASM_X86_ALTER

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-28 Thread Andrew Cooper
On 28/02/18 16:22, Jan Beulich wrote: On 26.02.18 at 12:35, wrote: >> Newer versions of binutils are capable of emitting an exact number bytes >> worth >> of optimised nops. Use this in preference to .skip when available. >> >> Signed-off-by: Andrew Cooper > In principle > Reviewed-by: Jan

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-28 Thread Jan Beulich
>>> On 26.02.18 at 12:35, wrote: > Newer versions of binutils are capable of emitting an exact number bytes worth > of optimised nops. Use this in preference to .skip when available. > > Signed-off-by: Andrew Cooper In principle Reviewed-by: Jan Beulich However, ... > RFC until support is ac

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-26 Thread Roger Pau Monné
On Mon, Feb 26, 2018 at 01:08:05PM +, Andrew Cooper wrote: > On 26/02/18 12:31, Roger Pau Monné wrote: > > On Mon, Feb 26, 2018 at 11:35:04AM +, Andrew Cooper wrote: > >> Newer versions of binutils are capable of emitting an exact number bytes > >> worth > >> of optimised nops. Use this i

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-26 Thread Andrew Cooper
On 26/02/18 12:31, Roger Pau Monné wrote: > On Mon, Feb 26, 2018 at 11:35:04AM +, Andrew Cooper wrote: >> Newer versions of binutils are capable of emitting an exact number bytes >> worth >> of optimised nops. Use this in preference to .skip when available. >> >> Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-26 Thread Roger Pau Monné
On Mon, Feb 26, 2018 at 11:35:04AM +, Andrew Cooper wrote: > Newer versions of binutils are capable of emitting an exact number bytes worth > of optimised nops. Use this in preference to .skip when available. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Konrad Rzeszutek Wi

[Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-02-26 Thread Andrew Cooper
Newer versions of binutils are capable of emitting an exact number bytes worth of optimised nops. Use this in preference to .skip when available. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Roger Pau Monné CC: Wei Liu RFC until support is actually committe