Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 09:57, wrote: > With this being rebased on top of v4 1/3: > > Reviewed-by: Sergey Dyasli Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-13 Thread Sergey Dyasli
On Wed, 2018-09-12 at 11:23 +0100, Andrew Cooper wrote: > On 12/09/18 10:46, Sergey Dyasli wrote: > > On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: > > > On 12/09/18 09:29, Sergey Dyasli wrote: > > > > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > > > > > Rename them to

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 11:05, Jan Beulich wrote: On 12.09.18 at 11:24, wrote: >> On 12/09/18 10:17, Jan Beulich wrote: >> On 12.09.18 at 11:12, wrote: On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> @@ -822,13 +818,13 @@ int

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 10:46, Sergey Dyasli wrote: > On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: >> On 12/09/18 09:29, Sergey Dyasli wrote: >>> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:24, wrote: > On 12/09/18 10:17, Jan Beulich wrote: > On 12.09.18 at 11:12, wrote: >>> On 12/09/18 09:29, Sergey Dyasli wrote: On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t >

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: > On 12/09/18 09:29, Sergey Dyasli wrote: > > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > > > Rename them to guest_{rd,wr}msr_xen() for consistency, and because the > > > _regs > > > suffix isn't very appropriate. > > > > > >

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 10:17, Jan Beulich wrote: On 12.09.18 at 11:12, wrote: >> On 12/09/18 09:29, Sergey Dyasli wrote: >>> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t val) if ( p2m_is_paging(t) )

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:12, wrote: > On 12/09/18 09:29, Sergey Dyasli wrote: >> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >>> @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t val) >>> if ( p2m_is_paging(t) ) >>> { >>>

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs >> suffix isn't very appropriate. >> >> Update them to take a vcpu pointer rather than presuming that they act on >>

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs > suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, and switch to using X86EMUL_* return

[Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-11 Thread Andrew Cooper
Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs suffix isn't very appropriate. Update them to take a vcpu pointer rather than presuming that they act on current, and switch to using X86EMUL_* return values. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei