Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-17 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 10 March 2020 14:19 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Varad Gautam' ; 'Julien > Grall' ; > 'Roger Pau Monné' ; 'Andrew Cooper' > > Subject: Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for >

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-10 Thread Jan Beulich
On 09.03.2020 18:47, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 09 March 2020 16:29 >> To: p...@xen.org >> Cc: xen-devel@lists.xenproject.org; Varad Gautam ; Julien >> Grall ; Roger >> Pau Monné ; Andrew Cooper >> Subject: Re: [PATCH v4] x86: irq: Do not

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-10 Thread Jan Beulich
On 10.03.2020 13:36, Paul Durrant wrote: > Ok, I'll convert back to a BUG(). Wait a little - I think I have an alternative proposal. Just want to at least smoke test it before sending out. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-10 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 10 March 2020 11:23 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Varad Gautam' ; 'Julien > Grall' ; > 'Roger Pau Monné' ; 'Andrew Cooper' > > Subject: Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for >

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-10 Thread Jan Beulich
On 09.03.2020 18:47, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 09 March 2020 16:29 >> >> On 06.03.2020 17:02, p...@xen.org wrote: >>> --- a/xen/arch/x86/irq.c >>> +++ b/xen/arch/x86/irq.c >>> @@ -1680,9 +1680,23 @@ static irq_guest_action_t

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 09 March 2020 16:29 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Varad Gautam ; Julien > Grall ; Roger > Pau Monné ; Andrew Cooper > Subject: Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for > shared pirqs >

Re: [Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-09 Thread Jan Beulich
On 06.03.2020 17:02, p...@xen.org wrote: > From: Varad Gautam > > XEN_DOMCTL_destroydomain creates a continuation if domain_kill -ERESTARTS. > In that scenario, it is possible to receive multiple __pirq_guest_unbind > calls for the same pirq from domain_kill, if the pirq has not yet been >

[Xen-devel] [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-03-06 Thread paul
From: Varad Gautam XEN_DOMCTL_destroydomain creates a continuation if domain_kill -ERESTARTS. In that scenario, it is possible to receive multiple __pirq_guest_unbind calls for the same pirq from domain_kill, if the pirq has not yet been removed from the domain's pirq_tree, as: domain_kill()