Re: [Xen-devel] [PATCH v4 1/6] microcode/intel: extend microcode_update_match()

2018-11-29 Thread Roger Pau Monné
On Thu, Nov 29, 2018 at 10:00:34AM +0800, Chao Gao wrote: > On Wed, Nov 28, 2018 at 11:58:06AM +0100, Roger Pau Monné wrote: > >On Wed, Nov 28, 2018 at 01:34:11PM +0800, Chao Gao wrote: > >> static int microcode_sanity_check(void *mc) > >> @@ -236,31 +259,13 @@ static int

Re: [Xen-devel] [PATCH v4 1/6] microcode/intel: extend microcode_update_match()

2018-11-28 Thread Chao Gao
On Wed, Nov 28, 2018 at 11:58:06AM +0100, Roger Pau Monné wrote: >On Wed, Nov 28, 2018 at 01:34:11PM +0800, Chao Gao wrote: >> to a more generic function. The benefit is that this function can be >> used to check whether a microcode is newer than another as well. We >> rely on this function to

Re: [Xen-devel] [PATCH v4 1/6] microcode/intel: extend microcode_update_match()

2018-11-28 Thread Roger Pau Monné
On Wed, Nov 28, 2018 at 01:34:11PM +0800, Chao Gao wrote: > to a more generic function. The benefit is that this function can be > used to check whether a microcode is newer than another as well. We > rely on this function to decide to perform a replacement or an add when > updating the global

[Xen-devel] [PATCH v4 1/6] microcode/intel: extend microcode_update_match()

2018-11-27 Thread Chao Gao
to a more generic function. The benefit is that this function can be used to check whether a microcode is newer than another as well. We rely on this function to decide to perform a replacement or an add when updating the global microcode cache (introduced by later patches in this series).