Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2019-01-15 Thread Andrew Cooper
On 29/11/2018 10:19, Jan Beulich wrote: On 29.11.18 at 03:40, wrote: >> On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: >>> On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: @@ -491,6 +559,21 @@ static int cpu_request_microcode(unsigned int cpu, const void

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2019-01-15 Thread Andrew Cooper
On 30/11/2018 09:32, Jan Beulich wrote: On 30.11.18 at 08:55, wrote: >> On Thu, Nov 29, 2018 at 10:22:10AM +0100, Roger Pau Monné wrote: >>> On Thu, Nov 29, 2018 at 10:40:32AM +0800, Chao Gao wrote: On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: > On Wed, Nov 28,

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-12-04 Thread Chao Gao
On Tue, Dec 04, 2018 at 10:39:03PM +, Woods, Brian wrote: >On Thu, Nov 29, 2018 at 10:22:10AM +0100, Roger Pau Monné wrote: >> On Thu, Nov 29, 2018 at 10:40:32AM +0800, Chao Gao wrote: >> > On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: >> > >On Wed, Nov 28, 2018 at

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-12-04 Thread Woods, Brian
On Thu, Nov 29, 2018 at 10:22:10AM +0100, Roger Pau Monné wrote: > On Thu, Nov 29, 2018 at 10:40:32AM +0800, Chao Gao wrote: > > On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: > > >On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: > > >> ... and search caches to find a

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-11-30 Thread Jan Beulich
>>> On 30.11.18 at 08:55, wrote: > On Thu, Nov 29, 2018 at 10:22:10AM +0100, Roger Pau Monné wrote: >>On Thu, Nov 29, 2018 at 10:40:32AM +0800, Chao Gao wrote: >>> On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: >>> >On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: >>>

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-11-29 Thread Chao Gao
On Thu, Nov 29, 2018 at 10:22:10AM +0100, Roger Pau Monné wrote: >On Thu, Nov 29, 2018 at 10:40:32AM +0800, Chao Gao wrote: >> On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: >> >On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: >> >> ... and search caches to find a

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-11-29 Thread Jan Beulich
>>> On 29.11.18 at 03:40, wrote: > On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: >>On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: >>> @@ -491,6 +559,21 @@ static int cpu_request_microcode(unsigned int cpu, >>> const void *buf, >>> while ( (error =

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-11-28 Thread Chao Gao
On Wed, Nov 28, 2018 at 01:00:14PM +0100, Roger Pau Monné wrote: >On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: >> ... and search caches to find a suitable one when loading. > >Why do you need to save all of them? You are only going to load a >single microcode, so I don't understand

Re: [Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-11-28 Thread Roger Pau Monné
On Wed, Nov 28, 2018 at 01:34:12PM +0800, Chao Gao wrote: > ... and search caches to find a suitable one when loading. Why do you need to save all of them? You are only going to load a single microcode, so I don't understand the need to cache them all. > With this cache, the existing 'uci->mc'

[Xen-devel] [PATCH v4 2/6] microcode: save all microcodes which pass sanity check

2018-11-27 Thread Chao Gao
... and search caches to find a suitable one when loading. With this cache, the existing 'uci->mc' structure is redundent. I deliberately avoid touching 'uci->mc' as I am going to remove it completely in the next patch. Signed-off-by: Chao Gao --- xen/arch/x86/microcode.c| 2 +