Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 11.03.20 12:33, Jan Beulich wrote: On 11.03.2020 10:47, Jürgen Groß wrote: On 11.03.20 10:36, Jan Beulich wrote: On 11.03.2020 10:27, Jürgen Groß wrote: On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jan Beulich
On 11.03.2020 10:47, Jürgen Groß wrote: > On 11.03.20 10:36, Jan Beulich wrote: >> On 11.03.2020 10:27, Jürgen Groß wrote: >>> On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: > On 10.03.20 18:02, Jan Beulich wrote: >> On 10.03.2020 08:28, Juergen Gross

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 11.03.20 10:36, Jan Beulich wrote: On 11.03.2020 10:27, Jürgen Groß wrote: On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jan Beulich
On 11.03.2020 10:27, Jürgen Groß wrote: > On 11.03.20 10:25, Jan Beulich wrote: >> On 11.03.2020 07:07, Jürgen Groß wrote: >>> On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -587,7 +587,7 @@ static void

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jan Beulich
On 11.03.2020 07:07, Jürgen Groß wrote: > On 10.03.20 18:02, Jan Beulich wrote: >> On 10.03.2020 08:28, Juergen Gross wrote: >>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >>> @@ -587,7 +587,7 @@ static void

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -25,7 +25,7 @@ static softirq_handler softirq_handlers[NR_SOFTIRQS]; static DEFINE_PER_CPU(cpumask_t, batch_mask); static DEFINE_PER_CPU(unsigned int,

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-10 Thread Jan Beulich
On 10.03.2020 08:28, Juergen Gross wrote: > --- a/xen/common/softirq.c > +++ b/xen/common/softirq.c > @@ -25,7 +25,7 @@ static softirq_handler softirq_handlers[NR_SOFTIRQS]; > static DEFINE_PER_CPU(cpumask_t, batch_mask); > static DEFINE_PER_CPU(unsigned int, batching); > > -static void

[Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-10 Thread Juergen Gross
Some keyhandlers are calling process_pending_softirqs() while holding a rcu_read_lock(). This is wrong, as process_pending_softirqs() might activate rcu calls which should not happen inside a rcu_read_lock(). For that purpose add process_pending_softirqs_norcu() which will not do any rcu activity