Re: [Xen-devel] [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode()

2018-11-30 Thread Jan Beulich
>>> On 30.11.18 at 09:57, wrote: > On Thu, Nov 29, 2018 at 10:46:05AM +0100, Roger Pau Monné wrote: >>On Thu, Nov 29, 2018 at 12:28:46PM +0800, Chao Gao wrote: >>> It is better that all CPUs have the same microcode revision. >>> >>> Linux kernel rejects late microcode update if finding some

Re: [Xen-devel] [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode()

2018-11-30 Thread Chao Gao
On Thu, Nov 29, 2018 at 10:46:05AM +0100, Roger Pau Monné wrote: >On Thu, Nov 29, 2018 at 12:28:46PM +0800, Chao Gao wrote: >> On Wed, Nov 28, 2018 at 04:02:25PM +0100, Roger Pau Monné wrote: >> >On Wed, Nov 28, 2018 at 01:34:14PM +0800, Chao Gao wrote: >> >> diff --git a/xen/arch/x86/microcode.c

Re: [Xen-devel] [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode()

2018-11-29 Thread Roger Pau Monné
On Thu, Nov 29, 2018 at 12:28:46PM +0800, Chao Gao wrote: > On Wed, Nov 28, 2018 at 04:02:25PM +0100, Roger Pau Monné wrote: > >On Wed, Nov 28, 2018 at 01:34:14PM +0800, Chao Gao wrote: > >> diff --git a/xen/arch/x86/microcode.c b/xen/arch/x86/microcode.c > >> index 8350d22..cca7b2c 100644 > >>

Re: [Xen-devel] [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode()

2018-11-28 Thread Chao Gao
On Wed, Nov 28, 2018 at 04:02:25PM +0100, Roger Pau Monné wrote: >On Wed, Nov 28, 2018 at 01:34:14PM +0800, Chao Gao wrote: >> cpu_request_microcode() will only parse microcode file and save >> suitable microcodes to microcode_cache. To update microcode, >> apply_microcode() should be invoked

Re: [Xen-devel] [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode()

2018-11-28 Thread Roger Pau Monné
On Wed, Nov 28, 2018 at 01:34:14PM +0800, Chao Gao wrote: > cpu_request_microcode() will only parse microcode file and save > suitable microcodes to microcode_cache. To update microcode, > apply_microcode() should be invoked explicitly. > > On AMD side, svm_host_osvw_init() is supposed to be

[Xen-devel] [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode()

2018-11-27 Thread Chao Gao
cpu_request_microcode() will only parse microcode file and save suitable microcodes to microcode_cache. To update microcode, apply_microcode() should be invoked explicitly. On AMD side, svm_host_osvw_init() is supposed to be called after microcode update. As apply_micrcode() won't be called by