Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-08 Thread Marek Marczykowski-Górecki
On Fri, Feb 08, 2019 at 10:35:37AM +0100, Roger Pau Monné wrote: > What about hot-unplug? The proper flow there would be to ask the > stubdomain to detach the device, and only deassign it after the > stubdomain has reported successful detach. I think that's already the > case. I think so. The app

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-08 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 06:51:57PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 06:40:16PM +0100, Roger Pau Monné wrote: > > On Thu, Feb 07, 2019 at 04:41:38PM +0100, Marek Marczykowski-Górecki wrote: > > > On Thu, Feb 07, 2019 at 03:57:54PM +0100, Roger Pau Monné wrote: > > >

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 06:40:16PM +0100, Roger Pau Monné wrote: > On Thu, Feb 07, 2019 at 04:41:38PM +0100, Marek Marczykowski-Górecki wrote: > > On Thu, Feb 07, 2019 at 03:57:54PM +0100, Roger Pau Monné wrote: > > > On Thu, Feb 07, 2019 at 03:52:38PM +0100, Marek Marczykowski-Górecki > > > wrote

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 04:41:38PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 03:57:54PM +0100, Roger Pau Monné wrote: > > On Thu, Feb 07, 2019 at 03:52:38PM +0100, Marek Marczykowski-Górecki wrote: > > > On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 03:57:54PM +0100, Roger Pau Monné wrote: > On Thu, Feb 07, 2019 at 03:52:38PM +0100, Marek Marczykowski-Górecki wrote: > > On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki wrote: > > > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > >

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 03:52:38PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki wrote: > > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 02:21:27PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > > > From: Simon Gaiser > > > > > > Stubdomains need to be given sufficie

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 02:21:24PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > > > diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c > > > index 8b44d

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 07, 2019 at 10:57:19AM +0100, Roger Pau Monné wrote: > On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > > From: Simon Gaiser > > > > Stubdomains need to be given sufficient privilege over the guest which it > > provides emulation for in order for PCI passt

Re: [Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 01:07:47AM +0100, Marek Marczykowski-Górecki wrote: > From: Simon Gaiser > > Stubdomains need to be given sufficient privilege over the guest which it > provides emulation for in order for PCI passthrough to work correctly. > When a HVM domain try to enable MSI, QEMU in st

[Xen-devel] [PATCH v4 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-02-06 Thread Marek Marczykowski-Górecki
From: Simon Gaiser Stubdomains need to be given sufficient privilege over the guest which it provides emulation for in order for PCI passthrough to work correctly. When a HVM domain try to enable MSI, QEMU in stubdomain calls PHYSDEVOP_map_pirq, but later it needs to call XEN_DOMCTL_bind_pt_irq a