Re: [Xen-devel] [PATCH v5 12/12] x86/hyperv: setup VP assist page

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 01:42:29PM +0100, Roger Pau Monné wrote: > On Wed, Jan 29, 2020 at 08:20:34PM +, Wei Liu wrote: > > VP assist page is rather important as we need to toggle some bits in it > > for efficient nested virtualisation. > > > > Signed-off-by: Wei Liu > > --- > > v5: > > 1.

Re: [Xen-devel] [PATCH v5 12/12] x86/hyperv: setup VP assist page

2020-01-30 Thread Wei Liu
On Thu, Jan 30, 2020 at 10:34:29AM +, Durrant, Paul wrote: > > + > > +val = (virt_to_mfn(mapping) << HV_HYP_PAGE_SHIFT) > > +| HV_X64_MSR_VP_ASSIST_PAGE_ENABLE; > > Perhaps it would be neater to put the viridian_page_msr union into > hyperv-tlfs.h and then use that. Done. Now

Re: [Xen-devel] [PATCH v5 12/12] x86/hyperv: setup VP assist page

2020-01-30 Thread Roger Pau Monné
On Wed, Jan 29, 2020 at 08:20:34PM +, Wei Liu wrote: > VP assist page is rather important as we need to toggle some bits in it > for efficient nested virtualisation. > > Signed-off-by: Wei Liu > --- > v5: > 1. Deal with error properly instead of always panicking > 2. Swap percpu variables

Re: [Xen-devel] [PATCH v5 12/12] x86/hyperv: setup VP assist page

2020-01-30 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 29 January 2020 20:21 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: [PATCH v5 12/12] x86/hyperv: setup VP assist page

[Xen-devel] [PATCH v5 12/12] x86/hyperv: setup VP assist page

2020-01-29 Thread Wei Liu
VP assist page is rather important as we need to toggle some bits in it for efficient nested virtualisation. Signed-off-by: Wei Liu --- v5: 1. Deal with error properly instead of always panicking 2. Swap percpu variables declarations' location v4: 1. Use private.h 2. Prevent leak v3: 1. Use