Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-12 Thread Roger Pau Monné
On Wed, Mar 11, 2020 at 05:20:23PM +0100, Jan Beulich wrote: > On 11.03.2020 16:51, Roger Pau Monné wrote: > > On Wed, Mar 11, 2020 at 04:37:50PM +0100, Jan Beulich wrote: > >> On 11.03.2020 16:34, Roger Pau Monné wrote: > >>> On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: > On 2

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Jan Beulich
On 11.03.2020 16:51, Roger Pau Monné wrote: > On Wed, Mar 11, 2020 at 04:37:50PM +0100, Jan Beulich wrote: >> On 11.03.2020 16:34, Roger Pau Monné wrote: >>> On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: On 28.02.2020 13:07, Roger Pau Monne wrote: > Current usage of the per-

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Roger Pau Monné
On Wed, Mar 11, 2020 at 04:37:50PM +0100, Jan Beulich wrote: > On 11.03.2020 16:34, Roger Pau Monné wrote: > > On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: > >> On 28.02.2020 13:07, Roger Pau Monne wrote: > >>> Current usage of the per-CPU scratch cpumask is dangerous since > >>> th

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Jan Beulich
On 11.03.2020 16:34, Roger Pau Monné wrote: > On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: >> On 28.02.2020 13:07, Roger Pau Monne wrote: >>> Current usage of the per-CPU scratch cpumask is dangerous since >>> there's no way to figure out if the mask is already being used except >>>

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Roger Pau Monné
On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: > On 28.02.2020 13:07, Roger Pau Monne wrote: > > Current usage of the per-CPU scratch cpumask is dangerous since > > there's no way to figure out if the mask is already being used except > > for manual code inspection of all the callers

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-02-28 Thread Jan Beulich
On 28.02.2020 13:07, Roger Pau Monne wrote: > Current usage of the per-CPU scratch cpumask is dangerous since > there's no way to figure out if the mask is already being used except > for manual code inspection of all the callers and possible call paths. > > This is unsafe and not reliable, so int

[Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-02-28 Thread Roger Pau Monne
Current usage of the per-CPU scratch cpumask is dangerous since there's no way to figure out if the mask is already being used except for manual code inspection of all the callers and possible call paths. This is unsafe and not reliable, so introduce a minimal get/put infrastructure to prevent nes