Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-22 Thread Julien Grall
On 22/07/2019 10:06, Julien Grall wrote: Hi Roger, On 22/07/2019 09:45, Roger Pau Monné wrote: On Sun, Jul 21, 2019 at 07:05:16PM +0100, Julien Grall wrote: Hi, On 7/20/19 10:21 PM, Marek Marczykowski-Górecki wrote: On Sat, Jul 20, 2019 at 05:48:56PM +0100, Julien Grall wrote: Hi, Sorry

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-22 Thread Julien Grall
Hi Roger, On 22/07/2019 09:45, Roger Pau Monné wrote: On Sun, Jul 21, 2019 at 07:05:16PM +0100, Julien Grall wrote: Hi, On 7/20/19 10:21 PM, Marek Marczykowski-Górecki wrote: On Sat, Jul 20, 2019 at 05:48:56PM +0100, Julien Grall wrote: Hi, Sorry for jumping late in the discussion. On

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-22 Thread Roger Pau Monné
On Sun, Jul 21, 2019 at 07:05:16PM +0100, Julien Grall wrote: > Hi, > > On 7/20/19 10:21 PM, Marek Marczykowski-Górecki wrote: > > On Sat, Jul 20, 2019 at 05:48:56PM +0100, Julien Grall wrote: > > > Hi, > > > > > > Sorry for jumping late in the discussion. > > > > > > On 7/17/19 2:00 AM, Marek

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-21 Thread Julien Grall
Hi, On 7/20/19 10:21 PM, Marek Marczykowski-Górecki wrote: On Sat, Jul 20, 2019 at 05:48:56PM +0100, Julien Grall wrote: Hi, Sorry for jumping late in the discussion. On 7/17/19 2:00 AM, Marek Marczykowski-Górecki wrote: diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-20 Thread Marek Marczykowski-Górecki
On Sat, Jul 20, 2019 at 05:48:56PM +0100, Julien Grall wrote: > Hi, > > Sorry for jumping late in the discussion. > > On 7/17/19 2:00 AM, Marek Marczykowski-Górecki wrote: > > diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h > > index 586b783..c7a6a83 100644 > > ---

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-20 Thread Julien Grall
Hi, Sorry for jumping late in the discussion. On 7/17/19 2:00 AM, Marek Marczykowski-Górecki wrote: diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index 586b783..c7a6a83 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -91,6 +91,7 @@ typedef struct irq_desc {

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-18 Thread Roger Pau Monné
On Thu, Jul 18, 2019 at 05:12:54PM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Jul 18, 2019 at 11:29:39AM +0200, Roger Pau Monné wrote: > > On Wed, Jul 17, 2019 at 05:09:12PM +0200, Marek Marczykowski-Górecki wrote: > > > On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote: > >

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-18 Thread Marek Marczykowski-Górecki
On Thu, Jul 18, 2019 at 11:29:39AM +0200, Roger Pau Monné wrote: > On Wed, Jul 17, 2019 at 05:09:12PM +0200, Marek Marczykowski-Górecki wrote: > > On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote: > > > On Wed, Jul 17, 2019 at 03:00:42AM +0200, Marek Marczykowski-Górecki > > >

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-18 Thread Roger Pau Monné
On Wed, Jul 17, 2019 at 05:09:12PM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote: > > On Wed, Jul 17, 2019 at 03:00:42AM +0200, Marek Marczykowski-Górecki wrote: > > > @@ -220,14 +237,22 @@ void destroy_irq(unsigned int irq) > > > > >

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-17 Thread Marek Marczykowski-Górecki
On Wed, Jul 17, 2019 at 11:54:35AM +0200, Roger Pau Monné wrote: > On Wed, Jul 17, 2019 at 03:00:42AM +0200, Marek Marczykowski-Górecki wrote: > > Stubdomains need to be given sufficient privilege over the guest which it > > provides emulation for in order for PCI passthrough to work correctly. >

Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-17 Thread Roger Pau Monné
On Wed, Jul 17, 2019 at 03:00:42AM +0200, Marek Marczykowski-Górecki wrote: > Stubdomains need to be given sufficient privilege over the guest which it > provides emulation for in order for PCI passthrough to work correctly. > When a HVM domain try to enable MSI, QEMU in stubdomain calls >

[Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.

2019-07-16 Thread Marek Marczykowski-Górecki
Stubdomains need to be given sufficient privilege over the guest which it provides emulation for in order for PCI passthrough to work correctly. When a HVM domain try to enable MSI, QEMU in stubdomain calls PHYSDEVOP_map_pirq, but later it needs to call XEN_DOMCTL_bind_pt_irq as part of