Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-18 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 18 February 2020 11:48 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Anthony Perard > ; Andrew Cooper ; > George Dunlap ; Jan Beulich ; > Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; > Jason Andryuk

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-18 Thread Ian Jackson
Durrant, Paul writes ("RE: [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid"): > Ian Jackson > > Sorry if I was confused; I will read this again. > > It is hard to follow the error paths. Early on in development I ended up with > domains getting destroyed when I

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-18 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 18 February 2020 11:17 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Anthony Perard > ; Andrew Cooper ; > George Dunlap ; Jan Beulich ; > Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; > Jason Andryuk

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-18 Thread Ian Jackson
Durrant, Paul writes ("RE: [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid"): > No, the domain will not be leaked. The existing failure handling in libxl > will clean up if *domid != INVALID_DOMID. Sorry if I was confused; I will read this again. > > > diff

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-18 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 17 February 2020 17:52 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Anthony Perard > ; Andrew Cooper ; > George Dunlap ; Jan Beulich ; > Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; > Jason Andryuk

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-17 Thread Ian Jackson
Paul Durrant writes ("[PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid"): > This patch adds a 'domid' field to libxl_domain_create_info and then > modifies libxl__domain_make() to have Xen use that value if it is valid. > If the domid value is invalid then Xen will

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-02 Thread Durrant, Paul
> -Original Message- > From: jandr...@gmail.com > Sent: 31 January 2020 17:23 > To: Durrant, Paul > Cc: xen-devel ; Ian Jackson > ; Wei Liu ; Anthony PERARD > ; Andrew Cooper ; > George Dunlap ; Jan Beulich > ; Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini > Subject: Re:

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-01-31 Thread Jason Andryuk
On Fri, Jan 31, 2020 at 10:02 AM Paul Durrant wrote: > > This patch adds a 'domid' field to libxl_domain_create_info and then > modifies libxl__domain_make() to have Xen use that value if it is valid. > If the domid value is invalid then Xen will choose the domid, as before, > unless the value is

[Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-01-31 Thread Paul Durrant
This patch adds a 'domid' field to libxl_domain_create_info and then modifies libxl__domain_make() to have Xen use that value if it is valid. If the domid value is invalid then Xen will choose the domid, as before, unless the value is the new special RANDOM_DOMID value added to the API. This value