Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jürgen Groß
On 09.03.20 14:06, Jan Beulich wrote: On 09.03.2020 14:01, Jürgen Groß wrote: On 09.03.20 12:55, Jan Beulich wrote: On 09.03.2020 12:43, Julien Grall wrote: On 26/02/2020 12:46, Juergen Gross wrote: @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[];

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jan Beulich
On 09.03.2020 14:01, Jürgen Groß wrote: > On 09.03.20 12:55, Jan Beulich wrote: >> On 09.03.2020 12:43, Julien Grall wrote: >>> On 26/02/2020 12:46, Juergen Gross wrote: @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __kparam

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jürgen Groß
On 09.03.20 12:55, Jan Beulich wrote: On 09.03.2020 12:43, Julien Grall wrote: On 26/02/2020 12:46, Juergen Gross wrote: @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], __param_end[]; __kparam __setup_##_var = \ { .name = __setup_str_##_var, \

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Jan Beulich
On 09.03.2020 12:43, Julien Grall wrote: > On 26/02/2020 12:46, Juergen Gross wrote: >> @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], >> __param_end[]; >> __kparam __setup_##_var = \ >> { .name = __setup_str_##_var, \ >> .type = OPT_BOOL, \ >> -

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-09 Thread Julien Grall
Hi Juergen, On 26/02/2020 12:46, Juergen Gross wrote: Support of other variable sizes than that of normal bool ones for boolean_parameter() don't make sense, so catch any other sized variables at build time. Fix the one parameter using a plain int instead of bool. Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-03-03 Thread Jan Beulich
On 26.02.2020 13:46, Juergen Gross wrote: > Support of other variable sizes than that of normal bool ones for > boolean_parameter() don't make sense, so catch any other sized > variables at build time. Nit: boolean_param() > @@ -46,7 +48,8 @@ extern const struct kernel_param __param_start[], >

[Xen-devel] [PATCH v6 01/12] xen: allow only sizeof(bool) variables for boolean_param()

2020-02-26 Thread Juergen Gross
Support of other variable sizes than that of normal bool ones for boolean_parameter() don't make sense, so catch any other sized variables at build time. Fix the one parameter using a plain int instead of bool. Signed-off-by: Juergen Gross --- V6: - new patch --- xen/arch/x86/hvm/asid.c | 2 +-