Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Roger Pau Monné
On Mon, Feb 03, 2020 at 03:42:17PM +, Wei Liu wrote: > On Mon, Feb 03, 2020 at 04:32:52PM +0100, Jan Beulich wrote: > > On 03.02.2020 16:21, Roger Pau Monné wrote: > > > On Mon, Feb 03, 2020 at 03:07:24PM +, Wei Liu wrote: > > >> On Mon, Feb 03, 2020 at 04:01:54PM +0100, Roger Pau Monné

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Wei Liu
On Mon, Feb 03, 2020 at 04:32:52PM +0100, Jan Beulich wrote: > On 03.02.2020 16:21, Roger Pau Monné wrote: > > On Mon, Feb 03, 2020 at 03:07:24PM +, Wei Liu wrote: > >> On Mon, Feb 03, 2020 at 04:01:54PM +0100, Roger Pau Monné wrote: > >>> On Fri, Jan 31, 2020 at 05:49:24PM +, Wei Liu

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Jan Beulich
On 03.02.2020 16:21, Roger Pau Monné wrote: > On Mon, Feb 03, 2020 at 03:07:24PM +, Wei Liu wrote: >> On Mon, Feb 03, 2020 at 04:01:54PM +0100, Roger Pau Monné wrote: >>> On Fri, Jan 31, 2020 at 05:49:24PM +, Wei Liu wrote: Hyper-V uses a technique called overlay page for its

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Roger Pau Monné
On Mon, Feb 03, 2020 at 03:07:24PM +, Wei Liu wrote: > On Mon, Feb 03, 2020 at 04:01:54PM +0100, Roger Pau Monné wrote: > > On Fri, Jan 31, 2020 at 05:49:24PM +, Wei Liu wrote: > > > Hyper-V uses a technique called overlay page for its hypercall page. It > > > will insert a backing page to

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Wei Liu
On Mon, Feb 03, 2020 at 04:01:54PM +0100, Roger Pau Monné wrote: > On Fri, Jan 31, 2020 at 05:49:24PM +, Wei Liu wrote: > > Hyper-V uses a technique called overlay page for its hypercall page. It > > will insert a backing page to the guest when the hypercall functionality > > is enabled. That

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Roger Pau Monné
On Fri, Jan 31, 2020 at 05:49:24PM +, Wei Liu wrote: > Hyper-V uses a technique called overlay page for its hypercall page. It > will insert a backing page to the guest when the hypercall functionality > is enabled. That means we can use a page that is not backed by real > memory for hypercall

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Wei Liu
On Mon, Feb 03, 2020 at 02:21:14PM +0100, Jan Beulich wrote: > On 31.01.2020 18:49, Wei Liu wrote: > > +static void __init setup_hypercall_page(void) > > +{ > > +union hv_x64_msr_hypercall_contents hypercall_msr; > > +union hv_guest_os_id guest_id; > > +unsigned long mfn; > > + > > +

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Jan Beulich
On 31.01.2020 18:49, Wei Liu wrote: > +static void __init setup_hypercall_page(void) > +{ > +union hv_x64_msr_hypercall_contents hypercall_msr; > +union hv_guest_os_id guest_id; > +unsigned long mfn; > + > +BUILD_BUG_ON(HV_HYP_PAGE_SHIFT != PAGE_SHIFT); > + > +

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Wei Liu
On Mon, Feb 03, 2020 at 11:41:57AM +, Durrant, Paul wrote: > > -Original Message- > > From: Jan Beulich > > Sent: 03 February 2020 11:39 > > To: Durrant, Paul > > Cc: Wei Liu ; Xen Development List > de...@lists.xenproject.org>; Michael Kelley ; Wei > > Liu ; Andrew Cooper ; > >

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 February 2020 11:39 > To: Durrant, Paul > Cc: Wei Liu ; Xen Development List de...@lists.xenproject.org>; Michael Kelley ; Wei > Liu ; Andrew Cooper ; > Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/hyperv: setup hypercall page

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Jan Beulich
On 03.02.2020 12:37, Durrant, Paul wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 03 February 2020 11:34 >> To: Durrant, Paul >> Cc: Wei Liu ; Xen Development List > de...@lists.xenproject.org>; Michael Kelley ; Wei >> Liu ; Andrew Cooper ; >> Roger Pau Monné >> Subject: Re:

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 February 2020 11:34 > To: Durrant, Paul > Cc: Wei Liu ; Xen Development List de...@lists.xenproject.org>; Michael Kelley ; Wei > Liu ; Andrew Cooper ; > Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/hyperv: setup hypercall page

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Jan Beulich
On 03.02.2020 12:21, Durrant, Paul wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 03 February 2020 11:06 >> To: Durrant, Paul >> Cc: Wei Liu ; Xen Development List > de...@lists.xenproject.org>; Michael Kelley ; Wei >> Liu ; Andrew Cooper ; >> Roger Pau Monné >> Subject: Re:

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 February 2020 11:06 > To: Durrant, Paul > Cc: Wei Liu ; Xen Development List de...@lists.xenproject.org>; Michael Kelley ; Wei > Liu ; Andrew Cooper ; > Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/hyperv: setup hypercall page

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Jan Beulich
On 03.02.2020 11:39, Durrant, Paul wrote: >> -Original Message- >> From: Wei Liu >> Sent: 31 January 2020 17:57 >> To: Xen Development List >> Cc: Durrant, Paul ; Michael Kelley >> ; Wei Liu ; Wei Liu >> ; Jan Beulich ; Andrew Cooper >> ; Roger Pau Monné >> Subject: Re: [PATCH v6 05/11]

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Wei Liu > Sent: 31 January 2020 17:57 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/hyperv: setup hypercall page > > (Note to

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-01-31 Thread Wei Liu
(Note to self) On Fri, Jan 31, 2020 at 05:49:24PM +, Wei Liu wrote: [...] > +static uint64_t generate_guest_id(void) > +{ > +union hv_guest_os_id id; > + id.raw = 0; > +id.vendor = HV_XEN_VENDOR_ID; > +id.major = xen_major_version(); > +id.minor = xen_minor_version();

[Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-01-31 Thread Wei Liu
Hyper-V uses a technique called overlay page for its hypercall page. It will insert a backing page to the guest when the hypercall functionality is enabled. That means we can use a page that is not backed by real memory for hypercall page. Use the top-most addressable page for that purpose.