Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-29 Thread Jan Beulich
>>> Chao Gao 01/28/19 12:59 PM >>> >On Fri, Jan 25, 2019 at 09:13:49AM -0700, Jan Beulich wrote: > On 25.01.19 at 09:26, wrote: >>> --- a/xen/arch/x86/domctl.c >>> +++ b/xen/arch/x86/domctl.c >>> @@ -732,7 +732,11 @@ long arch_do_domctl( >>> break; >>> >>> ret = -EPERM

Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-28 Thread Chao Gao
On Fri, Jan 25, 2019 at 09:13:49AM -0700, Jan Beulich wrote: On 25.01.19 at 09:26, wrote: >> --- a/xen/arch/x86/domctl.c >> +++ b/xen/arch/x86/domctl.c >> @@ -732,7 +732,11 @@ long arch_do_domctl( >> break; >> >> ret = -EPERM; >> -if ( irq <= 0 || !irq_access_p

Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-25 Thread Jan Beulich
>>> On 25.01.19 at 09:26, wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -732,7 +732,11 @@ long arch_do_domctl( > break; > > ret = -EPERM; > -if ( irq <= 0 || !irq_access_permitted(currd, irq) ) > +/* > + * irq < 0 denotes th

Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-25 Thread Roger Pau Monné
On Fri, Jan 25, 2019 at 07:36:36PM +0800, Chao Gao wrote: > On Fri, Jan 25, 2019 at 10:36:13AM +0100, Roger Pau Monné wrote: > >Thanks for the patch! > > > >On Fri, Jan 25, 2019 at 04:26:59PM +0800, Chao Gao wrote: > >> I find some pass-thru devices don't work any more across guest > >> reboot. Ass

Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-25 Thread Chao Gao
On Fri, Jan 25, 2019 at 10:36:13AM +0100, Roger Pau Monné wrote: >Thanks for the patch! > >On Fri, Jan 25, 2019 at 04:26:59PM +0800, Chao Gao wrote: >> I find some pass-thru devices don't work any more across guest >> reboot. Assigning it to another domain also meets the same issue. And >> the only

Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-25 Thread Roger Pau Monné
Thanks for the patch! On Fri, Jan 25, 2019 at 04:26:59PM +0800, Chao Gao wrote: > I find some pass-thru devices don't work any more across guest > reboot. Assigning it to another domain also meets the same issue. And > the only way to make it work again is un-binding and binding it to > pciback. S

[Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

2019-01-25 Thread Chao Gao
I find some pass-thru devices don't work any more across guest reboot. Assigning it to another domain also meets the same issue. And the only way to make it work again is un-binding and binding it to pciback. Someone reported this issue one year ago [1]. If the device's driver doesn't disable MSI-