>>> On 12.09.18 at 12:01, wrote:
> On 09/12/2018 10:15 AM, Jan Beulich wrote:
> On 12.09.18 at 11:10, wrote:
From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf
Of Jan Beulich
Sent: 11 September 2018 15:56
>>> On 23.08.18 at 11:47, wrote:
> .
zutek Wilk
> ; Tim (Xen.org)
> Subject: Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as
> a wrapper...
>
> On 09/12/2018 10:15 AM, Jan Beulich wrote:
> >>>> On 12.09.18 at 11:10, wrote:
> >>> From: Xen-devel [mailto:xen-devel-boun...@lists.xenp
On 09/12/2018 10:15 AM, Jan Beulich wrote:
On 12.09.18 at 11:10, wrote:
>>> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf
>>> Of Jan Beulich
>>> Sent: 11 September 2018 15:56
>>>
>> On 23.08.18 at 11:47, wrote:
...for some uses of get_page_from_gfn().
>>>
>>> On 12.09.18 at 11:10, wrote:
>> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf
>> Of Jan Beulich
>> Sent: 11 September 2018 15:56
>>
>> >>> On 23.08.18 at 11:47, wrote:
>> > ...for some uses of get_page_from_gfn().
>> >
>> > There are many occurences of the followi
er
> ; Ian Jackson ; Tim
> (Xen.org) ; Julien Grall ; xen-devel
>
> Subject: Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as
> a wrapper...
>
> >>> On 23.08.18 at 11:47, wrote:
> > ...for some uses of get_page_from_gfn().
> >
> > There
>>> On 23.08.18 at 11:47, wrote:
> ...for some uses of get_page_from_gfn().
>
> There are many occurences of the following pattern in the code:
>
> q = ? P2M_ALLOC : P2M_UNSHARE;
Especially with this UNSHARE in mind - is "paged" in the helper
function's name really suitable? Since we (I th
> -Original Message-
> From: Julien Grall [mailto:julien.gr...@arm.com]
> Sent: 23 August 2018 11:25
> To: Paul Durrant ; xen-devel@lists.xenproject.org
> Cc: Jan Beulich ; Andrew Cooper
> ; George Dunlap
> ; Ian Jackson ; Konrad
> Rzeszutek Wilk ; Stefano Stabellini
> ; Tim (Xen.org) ; Wei
Hi Paul,
On 08/23/2018 10:47 AM, Paul Durrant wrote:
...for some uses of get_page_from_gfn().
There are many occurences of the following pattern in the code:
NIT: s/occurences/occurences/
[...]
+int get_paged_gfn(struct domain *d, gfn_t gfn, bool readonly,
+ p2m_type_t *p2
...for some uses of get_page_from_gfn().
There are many occurences of the following pattern in the code:
q = ? P2M_ALLOC : P2M_UNSHARE;
page = get_page_from_gfn(d, gfn, &p2mt, q);
if ( p2m_is_paging(p2mt) )
{
if ( page )
put_page(page);
p2m_mem_pagin
