Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-07 Thread Julien Grall
Hi Stefano, On 2/6/19 7:35 PM, Stefano Stabellini wrote: On Wed, 6 Feb 2019, Julien Grall wrote: However, I think we should add some sanity check in arch_set_info_guest for our peace of mind. For guest entry/exit, rather than zero the upper 32-bits I would also add sanity check in enter_hypervi

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-06 Thread Stefano Stabellini
On Wed, 6 Feb 2019, Julien Grall wrote: > Hi Stefano, > > On 2/5/19 9:34 PM, Stefano Stabellini wrote: > > On Tue, 5 Feb 2019, Julien Grall wrote: > > > Sorry for the formatting. > > > > > > On Tue, 5 Feb 2019, 20:04 Stefano Stabellini, > > > wrote: > > >On Tue, 5 Feb 2019, Jan Beulich w

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-06 Thread Julien Grall
Hi Stefano, On 2/5/19 9:34 PM, Stefano Stabellini wrote: On Tue, 5 Feb 2019, Julien Grall wrote: Sorry for the formatting. On Tue, 5 Feb 2019, 20:04 Stefano Stabellini, wrote: On Tue, 5 Feb 2019, Jan Beulich wrote: But I am afraid this is not correct. Upper 32-bit of the register wi

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-05 Thread Stefano Stabellini
On Tue, 5 Feb 2019, Julien Grall wrote: > Sorry for the formatting. > > On Tue, 5 Feb 2019, 20:04 Stefano Stabellini, wrote: > On Tue, 5 Feb 2019, Jan Beulich wrote: > > >>> On 05.02.19 at 01:39, wrote: > > > On Wed, 30 Jan 2019, Christopher Clark wrote: > > >> +#include

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-05 Thread Julien Grall
Sorry for the formatting. On Tue, 5 Feb 2019, 20:04 Stefano Stabellini, wrote: > On Tue, 5 Feb 2019, Jan Beulich wrote: > > >>> On 05.02.19 at 01:39, wrote: > > > On Wed, 30 Jan 2019, Christopher Clark wrote: > > >> +#include > > >> +#include > > >> + > > >> +long > > >> +do_argo_op(unsigned

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-05 Thread Stefano Stabellini
On Tue, 5 Feb 2019, Jan Beulich wrote: > >>> On 05.02.19 at 01:39, wrote: > > On Wed, 30 Jan 2019, Christopher Clark wrote: > >> +#include > >> +#include > >> + > >> +long > >> +do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > >> + XEN_GUEST_HANDLE_PARAM(void) arg2, un

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-05 Thread Jan Beulich
>>> On 05.02.19 at 01:39, wrote: > On Wed, 30 Jan 2019, Christopher Clark wrote: >> +#include >> +#include >> + >> +long >> +do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, >> + XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3, >> + unsigned long arg4) >>

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-04 Thread Stefano Stabellini
On Wed, 30 Jan 2019, Christopher Clark wrote: > +#include > +#include > + > +long > +do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > + XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3, > + unsigned long arg4) > +{ > +return -ENOSYS; > +} > + > +#ifde

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-04 Thread Julien Grall
Hi Christopher, On 2/4/19 8:32 PM, Christopher Clark wrote: On Wed, Jan 30, 2019 at 8:14 PM Christopher Clark wrote: On Fri, Jan 25, 2019 at 10:55 AM Christopher Clark wrote: On Thu, Jan 24, 2019 at 2:08 AM Julien Grall wrote: [...] Sorry for noticing quite late in the process. Don't you

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-02-04 Thread Christopher Clark
On Wed, Jan 30, 2019 at 8:14 PM Christopher Clark wrote: > > On Fri, Jan 25, 2019 at 10:55 AM Christopher Clark > wrote: > > > > On Thu, Jan 24, 2019 at 2:08 AM Julien Grall wrote: > > > [...] > > > Sorry for noticing quite late in the process. Don't you need to add the > > > hypercall in xen/ar

Re: [Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-01-31 Thread Jan Beulich
>>> On 31.01.19 at 05:28, wrote: > Presence is gated upon CONFIG_ARGO. > > Registers the hypercall previously reserved for this. > Takes 5 arguments, does nothing and returns -ENOSYS. > > Implementation will provide a compat ABI so COMPAT_CALL is the > macro used in the hypercall tables. > > Si

[Xen-devel] [PATCH v7 02/15] argo: introduce the argo_op hypercall boilerplate

2019-01-30 Thread Christopher Clark
Presence is gated upon CONFIG_ARGO. Registers the hypercall previously reserved for this. Takes 5 arguments, does nothing and returns -ENOSYS. Implementation will provide a compat ABI so COMPAT_CALL is the macro used in the hypercall tables. Signed-off-by: Christopher Clark --- v6 dropped Jan A