Re: [Xen-devel] [PATCH v7 for-next 09/12] vpci/bars: add handlers to map the BARs

2018-01-19 Thread Roger Pau Monné
On Fri, Jan 19, 2018 at 09:16:54AM -0700, Jan Beulich wrote: > >>> On 19.01.18 at 16:47, wrote: > > On Fri, Dec 15, 2017 at 04:43:11AM -0700, Jan Beulich wrote: > >> >>> On 18.10.17 at 13:40, wrote: > >> > +static void modify_decoding(const struct

Re: [Xen-devel] [PATCH v7 for-next 09/12] vpci/bars: add handlers to map the BARs

2018-01-19 Thread Jan Beulich
>>> On 19.01.18 at 16:47, wrote: > On Fri, Dec 15, 2017 at 04:43:11AM -0700, Jan Beulich wrote: >> >>> On 18.10.17 at 13:40, wrote: >> > +static void modify_decoding(const struct pci_dev *pdev, bool map, bool >> > rom) >> > +{ >> > +struct

Re: [Xen-devel] [PATCH v7 for-next 09/12] vpci/bars: add handlers to map the BARs

2018-01-19 Thread Roger Pau Monné
Thanks for the review, and sorry for the very late reply. On Fri, Dec 15, 2017 at 04:43:11AM -0700, Jan Beulich wrote: > >>> On 18.10.17 at 13:40, wrote: > > +static void modify_decoding(const struct pci_dev *pdev, bool map, bool rom) > > +{ > > +struct vpci_header

Re: [Xen-devel] [PATCH v7 for-next 09/12] vpci/bars: add handlers to map the BARs

2017-12-15 Thread Jan Beulich
>>> On 18.10.17 at 13:40, wrote: > --- /dev/null > +++ b/xen/drivers/vpci/header.c > @@ -0,0 +1,518 @@ > +/* > + * Generic functionality for handling accesses to the PCI header from the > + * configuration space. > + * > + * Copyright (C) 2017 Citrix Systems R > + * > + *