Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Vladimir Sementsov-Ogievskiy
06.03.2020 15:37, Eric Blake wrote: On 3/5/20 11:15 PM, Vladimir Sementsov-Ogievskiy wrote: Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. As an aid to writing imperative-style commit messages, I like to prepend an implicit "Apply th

Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Eric Blake
On 3/5/20 11:15 PM, Vladimir Sementsov-Ogievskiy wrote: Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. As an aid to writing imperative-style commit messages, I like to prepend an implicit "Apply this patch to..." before the user's tex

Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Alberto Garcia
On Fri 06 Mar 2020 06:15:27 AM CET, Vladimir Sementsov-Ogievskiy wrote: Sorry I just gave a quick look at these patches and noticed this: > + * Function may use error system to return errors. In this case function > + * defines Error **errp parameter, which should be the last one (except for > +

Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Greg Kurz
On Fri, 6 Mar 2020 08:15:27 +0300 Vladimir Sementsov-Ogievskiy wrote: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with an errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal and error_prepend/error_append_hint: user > can't see t

Re: [Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Paul Durrant
On Fri, 6 Mar 2020 at 05:16, Vladimir Sementsov-Ogievskiy wrote: > > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with an errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal and error_prepend/error_append_hint: user > can't see this add

[Xen-devel] [PATCH v8 01/10] error: auto propagated local_err

2020-03-05 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. It has three goals: 1. Fix issue with error_fatal and error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than informati