Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-22 Thread Tamas K Lengyel
On Tue, May 22, 2018 at 6:24 AM, Jan Beulich wrote: On 21.05.18 at 18:59, wrote: >> After closer inspection the problem is with the following line here: >> for ( i = 1; i < argc; ++i ) >> >> This assumes that argv[0] is the EFI

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-22 Thread Jan Beulich
>>> On 21.05.18 at 18:59, wrote: > After closer inspection the problem is with the following line here: > >>> for ( i = 1; i < argc; ++i ) > > This assumes that argv[0] is the EFI executable filename, which is not > true when EFI_LOAD_OPTION is used. That's why in

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-22 Thread Jan Beulich
>>> On 21.05.18 at 18:59, wrote: > After closer inspection the problem is with the following line here: > >>> for ( i = 1; i < argc; ++i ) > > This assumes that argv[0] is the EFI executable filename, which is not > true when EFI_LOAD_OPTION is used. That's why in

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-21 Thread Tamas K Lengyel
On Thu, May 17, 2018 at 11:42 AM, Tamas K Lengyel wrote: > On Thu, May 17, 2018 at 2:03 AM, Jan Beulich wrote: > On 07.02.18 at 17:00, wrote: >>> This patch as-is correctly tells the two possible formats apart. I >>> tested and

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-17 Thread Tamas K Lengyel
On Thu, May 17, 2018 at 2:03 AM, Jan Beulich wrote: On 07.02.18 at 17:00, wrote: >> This patch as-is correctly tells the two possible formats apart. I >> tested and Xen boots correctly both from the Shell and from the >> firmware boot menu. I would

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-05-17 Thread Jan Beulich
>>> On 07.02.18 at 17:00, wrote: > This patch as-is correctly tells the two possible formats apart. I > tested and Xen boots correctly both from the Shell and from the > firmware boot menu. I would not like to start addressing hypothetical > scenarios that I have no

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-03-13 Thread Tamas K Lengyel
On Tue, Mar 13, 2018 at 1:47 AM, Jan Beulich wrote: On 12.03.18 at 16:00, wrote: >> Patch ping. Jan, I would like to touch base once more to see if we can >> get this patch included in 4.11. The patch as-is correctly tells the >> difference between

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-03-13 Thread Jan Beulich
>>> On 12.03.18 at 16:00, wrote: > Patch ping. Jan, I would like to touch base once more to see if we can > get this patch included in 4.11. The patch as-is correctly tells the > difference between buffers provided by both an EFI shell or by the > firmware as an

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-03-12 Thread Tamas K Lengyel
Patch ping. Jan, I would like to touch base once more to see if we can get this patch included in 4.11. The patch as-is correctly tells the difference between buffers provided by both an EFI shell or by the firmware as an EFI_LOAD_OPTION. Thanks, Tamas On Wed, Feb 7, 2018 at 9:00 AM, Tamas K

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 18:35, wrote: > On Fri, Jan 26, 2018 at 5:46 AM, Jan Beulich wrote: > On 23.01.18 at 01:21, wrote: >>> @@ -375,12 +385,39 @@ static void __init PrintErrMesg(const CHAR16 *mesg, >>> EFI_STATUS ErrCode) >>> >>>

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-26 Thread Tamas K Lengyel
On Fri, Jan 26, 2018 at 5:46 AM, Jan Beulich wrote: On 23.01.18 at 01:21, wrote: >> @@ -88,6 +88,16 @@ typedef struct _EFI_APPLE_PROPERTIES { >> EFI_APPLE_PROPERTIES_GETALL GetAll; >> } EFI_APPLE_PROPERTIES; >> >> +typedef struct

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-26 Thread Jan Beulich
>>> On 23.01.18 at 01:21, wrote: > @@ -88,6 +88,16 @@ typedef struct _EFI_APPLE_PROPERTIES { > EFI_APPLE_PROPERTIES_GETALL GetAll; > } EFI_APPLE_PROPERTIES; > > +typedef struct _EFI_LOAD_OPTION { > +UINT32 Attributes; > +UINT16 FilePathListLength; > +

[Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-22 Thread Tamas K Lengyel
When booting Xen via UEFI the Xen config file can contain multiple sections each describing different boot options. It is currently only possible to choose which section to boot with if the buffer contains a string. UEFI provides a different standard to pass optional arguments to an application,