Re: [Xen-devel] [RFC 05/16] gic-vgic: Drop an excessive clear_lrs

2018-12-12 Thread Julien Grall
On 12/12/2018 11:01, Andrii Anisov wrote: Hello Julien, On 11.12.18 16:33, Julien Grall wrote: With #ifndef NDEBUG and the appropriate comment: Will do. Reviewed-by: Julien Grall Thank you. Feel free to resent it alone so it can be merged to Xen 4.12. What about getting it together

Re: [Xen-devel] [RFC 05/16] gic-vgic: Drop an excessive clear_lrs

2018-12-12 Thread Andrii Anisov
Hello Julien, On 11.12.18 16:33, Julien Grall wrote: With #ifndef NDEBUG and the appropriate comment: Will do. Reviewed-by: Julien Grall Thank you. Feel free to resent it alone so it can be merged to Xen 4.12. What about getting it together with "[RFC 11/16] irq: skip action

Re: [Xen-devel] [RFC 05/16] gic-vgic: Drop an excessive clear_lrs

2018-12-11 Thread Julien Grall
Hi Andrii, On 28/11/2018 21:32, Andrii Anisov wrote: From: Andrii Anisov This action is excessive because for an invalid LR there is no need to write another invalid value to a register. So we can skip it here, saving a peripheral register access. Signed-off-by: Andrii Anisov ---

[Xen-devel] [RFC 05/16] gic-vgic: Drop an excessive clear_lrs

2018-11-28 Thread Andrii Anisov
From: Andrii Anisov This action is excessive because for an invalid LR there is no need to write another invalid value to a register. So we can skip it here, saving a peripheral register access. Signed-off-by: Andrii Anisov --- xen/arch/arm/gic-vgic.c | 1 - 1 file changed, 1 deletion(-)