Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-15 Thread Andrii Anisov
Hello Dario, On 13.08.19 17:45, Dario Faggioli wrote: What do you mean with "Yet its scheduling is very implementation dependant"? The freertos provides an interface to its scheduling internals like `vTaskSwitchContext` and `xTaskIncrementTick()`, which should be called by the

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-13 Thread Dario Faggioli
On Thu, 2019-08-08 at 17:07 +0300, Andrii Anisov wrote: > On 06.08.19 16:09, Andrii Anisov wrote: > > p.p.s. I'm looking through freertos as well to get wider look on > > the available approaches > > OK, basically Free-RTOS does not account the IRQ time separately. Yet > its scheduling is very

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-08 Thread Andrii Anisov
On 06.08.19 16:09, Andrii Anisov wrote: p.p.s. I'm looking through freertos as well to get wider look on the available approaches OK, basically Free-RTOS does not account the IRQ time separately. Yet its scheduling is very implementation dependent. Any ideas about other open-source examples

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-06 Thread Andrii Anisov
Hello Dario, Please see my comments below: On 03.08.19 03:55, Dario Faggioli wrote: On Fri, 2019-08-02 at 16:07 +0300, Andrii Anisov wrote: On 02.08.19 12:15, Julien Grall wrote: From the list below it is not clear what is the split between hypervisor time and guest time. See some of the

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Dario Faggioli
On Fri, 2019-08-02 at 14:49 +0100, Julien Grall wrote: > /!\/!\/!\ > > I am not a scheduler expert so my view maybe be wrong. Dario feel > free to > correct me :). > > /!\/!\/!\ > :-) > On 02/08/2019 14:07, Andrii Anisov wrote: > > On 02.08.19 12:15, Julien Grall wrote: > > > > > > But the

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Dario Faggioli
On Fri, 2019-08-02 at 16:07 +0300, Andrii Anisov wrote: > On 02.08.19 12:15, Julien Grall wrote: > > From the list below it is not clear what is the split between > > hypervisor time and guest time. See some of the examples below. > > I guess your question is *why* do I split hyp/guest time in

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Julien Grall
Hi, /!\/!\/!\ I am not a scheduler expert so my view maybe be wrong. Dario feel free to correct me :). /!\/!\/!\ On 02/08/2019 14:07, Andrii Anisov wrote: On 02.08.19 12:15, Julien Grall wrote: I can make such a list, how it is done in this series:  From the list below it is not clear

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Julien Grall
Hi Andrii, On 02/08/2019 13:24, Andrii Anisov wrote: On 02.08.19 12:03, Julien Grall wrote: A fair amount of leave_hypervisor_tail() deal with the guest itself (i.e vGIC, P2M...) All that stuff is what hypervisor does for the guest. And does behind the guest's back. Please define

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Andrii Anisov
On 02.08.19 12:15, Julien Grall wrote: I can make such a list, how it is done in this series: From the list below it is not clear what is the split between hypervisor time and guest time. See some of the examples below. I guess your question is *why* do I split hyp/guest time in such a

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Andrii Anisov
On 02.08.19 12:03, Julien Grall wrote: A fair amount of leave_hypervisor_tail() deal with the guest itself (i.e vGIC, P2M...) All that stuff is what hypervisor does for the guest. And does behind the guest's back. , so I think they should be accounted to the guest time. This point is

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Julien Grall
Hi, On 02/08/2019 08:50, Andrii Anisov wrote: Hello Dario On 01.08.19 14:19, Dario Faggioli wrote: On Thu, 2019-08-01 at 09:45 +0300, Andrii Anisov wrote: Hello Julien, On 30.07.19 23:10, Julien Grall wrote: In this series I think I need interrupts locked until I start time accounting for

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Julien Grall
On 02/08/2019 09:28, Andrii Anisov wrote: On 01.08.19 12:37, Julien Grall wrote: Hi, On 01/08/2019 07:45, Andrii Anisov wrote: On 30.07.19 23:10, Julien Grall wrote: In this series I think I need interrupts locked until I start time accounting for hypervisor. Time accounting is started

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Andrii Anisov
On 01.08.19 12:37, Julien Grall wrote: Hi, On 01/08/2019 07:45, Andrii Anisov wrote: On 30.07.19 23:10, Julien Grall wrote: In this series I think I need interrupts locked until I start time accounting for hypervisor. Time accounting is started by `tacc_head()` function. I prefer to have

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-02 Thread Andrii Anisov
Hello Dario On 01.08.19 14:19, Dario Faggioli wrote: On Thu, 2019-08-01 at 09:45 +0300, Andrii Anisov wrote: Hello Julien, On 30.07.19 23:10, Julien Grall wrote: In this series I think I need interrupts locked until I start time accounting for hypervisor. Time accounting is started by

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-01 Thread Dario Faggioli
On Thu, 2019-08-01 at 09:45 +0300, Andrii Anisov wrote: > Hello Julien, > > On 30.07.19 23:10, Julien Grall wrote: > > > > In this series I think I need interrupts locked until I start > > > time accounting for hypervisor. Time accounting is started by > > > `tacc_head()` function. I prefer to

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-01 Thread Julien Grall
Hi, On 01/08/2019 07:45, Andrii Anisov wrote: On 30.07.19 23:10, Julien Grall wrote: In this series I think I need interrupts locked until I start time accounting for hypervisor. Time accounting is started by `tacc_head()` function. I prefer to have it called from C, because it is more

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-08-01 Thread Andrii Anisov
Hello Julien, On 30.07.19 23:10, Julien Grall wrote: In this series I think I need interrupts locked until I start time accounting for hypervisor. Time accounting is started by `tacc_head()` function. I prefer to have it called from C, because it is more convenient and obvious for those who

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-07-30 Thread Andrii Anisov
On 26.07.19 13:48, Julien Grall wrote: This is the 3rd time you send this patch... and still no proper explanation why this is done nor the impact on keeping the interrupts disabled longer than necessary. I know it is the third time for this patch. Yet it is in the RFC series again. In this

Re: [Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-07-26 Thread Julien Grall
Hi, On 26/07/2019 11:37, Andrii Anisov wrote: From: Julien Grall This makes function enter_hypervisor_head() being executed with irqs locked. This is the 3rd time you send this patch... and still no proper explanation why this is done nor the impact on keeping the interrupts disabled

[Xen-devel] [RFC 1/6] xen/arm: Re-enable interrupt later in the trap path

2019-07-26 Thread Andrii Anisov
From: Julien Grall This makes function enter_hypervisor_head() being executed with irqs locked. Signed-off-by: Julien Grall [Andrii: add a justification commit message] Signed-off-by: Andrii Anisov --- xen/arch/arm/arm64/entry.S | 11 +-- xen/arch/arm/traps.c | 6 ++ 2