Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-28 Thread Julien Grall
On 28/11/2019 01:07, Stefano Stabellini wrote: On Wed, 27 Nov 2019, Julien Grall wrote: On Tue, 26 Nov 2019, 23:18 Stefano Stabellini, wrote: On Fri, 15 Nov 2019, Stewart Hildebrand wrote: > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > Use

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-27 Thread Stefano Stabellini
On Wed, 27 Nov 2019, Julien Grall wrote: > On Tue, 26 Nov 2019, 23:18 Stefano Stabellini, wrote: > On Fri, 15 Nov 2019, Stewart Hildebrand wrote: > > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > > > Use vcpu argument in vgic_connect_hw_irq. > > >

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-27 Thread Julien Grall
Hi, On 27/11/2019 18:48, Stefano Stabellini wrote: Yes, I think that is a good suggestion. I take that you mean that in vgic_disable_irqs for PPIs we would only clear GIC_IRQ_GUEST_ENABLED then return basically, right? Not really, I am only suggesting to remove the part if ( desc != NULL )

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-27 Thread Stefano Stabellini
On Tue, 26 Nov 2019, Julien Grall wrote: > On 26/11/2019 22:36, Stefano Stabellini wrote: > > On Mon, 25 Nov 2019, Julien Grall wrote: > > > On 23/11/2019 20:35, Julien Grall wrote: > > > > Hi, > > > > > > > > On 15/11/2019 20:10, Stewart Hildebrand wrote: > > > > > Allow vgic_get_hw_irq_desc to

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-26 Thread Julien Grall
On Tue, 26 Nov 2019, 23:18 Stefano Stabellini, wrote: > On Fri, 15 Nov 2019, Stewart Hildebrand wrote: > > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > > > Use vcpu argument in vgic_connect_hw_irq. > > > > vgic_connect_hw_irq is called for PPIs and SPIs, not SGIs. Enforce

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-26 Thread Stefano Stabellini
On Fri, 15 Nov 2019, Stewart Hildebrand wrote: > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > Use vcpu argument in vgic_connect_hw_irq. > > vgic_connect_hw_irq is called for PPIs and SPIs, not SGIs. Enforce with > ASSERTs. > > Signed-off-by: Stewart Hildebrand > > --- >

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-26 Thread Julien Grall
On 26/11/2019 22:36, Stefano Stabellini wrote: On Mon, 25 Nov 2019, Julien Grall wrote: On 23/11/2019 20:35, Julien Grall wrote: Hi, On 15/11/2019 20:10, Stewart Hildebrand wrote: Allow vgic_get_hw_irq_desc to be called with a vcpu argument. Use vcpu argument in vgic_connect_hw_irq.

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-26 Thread Stefano Stabellini
On Mon, 25 Nov 2019, Julien Grall wrote: > On 23/11/2019 20:35, Julien Grall wrote: > > Hi, > > > > On 15/11/2019 20:10, Stewart Hildebrand wrote: > > > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > > > > > Use vcpu argument in vgic_connect_hw_irq. > > > > > >

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-26 Thread Julien Grall
Hi, On 26/11/2019 01:20, Stefano Stabellini wrote: On Mon, 25 Nov 2019, Julien Grall wrote: (+ Andre) On 23/11/2019 20:35, Julien Grall wrote: Hi, On 15/11/2019 20:10, Stewart Hildebrand wrote: Allow vgic_get_hw_irq_desc to be called with a vcpu argument. Use vcpu argument in

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-25 Thread Stefano Stabellini
On Mon, 25 Nov 2019, Julien Grall wrote: > (+ Andre) > > On 23/11/2019 20:35, Julien Grall wrote: > > Hi, > > > > On 15/11/2019 20:10, Stewart Hildebrand wrote: > > > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > > > > > Use vcpu argument in vgic_connect_hw_irq. > > > > > >

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-25 Thread Julien Grall
(+ Andre) On 23/11/2019 20:35, Julien Grall wrote: Hi, On 15/11/2019 20:10, Stewart Hildebrand wrote: Allow vgic_get_hw_irq_desc to be called with a vcpu argument. Use vcpu argument in vgic_connect_hw_irq. vgic_connect_hw_irq is called for PPIs and SPIs, not SGIs. Enforce with ASSERTs.

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-23 Thread Julien Grall
Hi, On 15/11/2019 20:10, Stewart Hildebrand wrote: Allow vgic_get_hw_irq_desc to be called with a vcpu argument. Use vcpu argument in vgic_connect_hw_irq. vgic_connect_hw_irq is called for PPIs and SPIs, not SGIs. Enforce with ASSERTs. Signed-off-by: Stewart Hildebrand --- v3: new patch

[Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-15 Thread Stewart Hildebrand
Allow vgic_get_hw_irq_desc to be called with a vcpu argument. Use vcpu argument in vgic_connect_hw_irq. vgic_connect_hw_irq is called for PPIs and SPIs, not SGIs. Enforce with ASSERTs. Signed-off-by: Stewart Hildebrand --- v3: new patch --- Note: I have only modified the old vgic to allow