Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-09 Thread Tian, Kevin
> From: Jan Beulich > Sent: Thursday, March 5, 2020 5:24 PM > > On 26.02.2020 12:33, Anthony PERARD wrote: > > This is part of upgrading our build system and import more of Linux's > > one. > > > > In Linux, subdir-y in Makefiles is only used to descend into > > subdirectory when there are no

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Julien Grall
Hi Anthony, On 05/03/2020 15:59, Anthony PERARD wrote: On Thu, Mar 05, 2020 at 03:02:22PM +, Julien Grall wrote: Hi Jan, xen/Rules.mk | 19 --- xen/arch/arm/Makefile| 14 +++--- xen/arch/arm/arm32/Makefile |

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Anthony PERARD
On Thu, Mar 05, 2020 at 03:02:22PM +, Julien Grall wrote: > Hi Jan, > > > > xen/Rules.mk | 19 --- > > > xen/arch/arm/Makefile| 14 +++--- > > > xen/arch/arm/arm32/Makefile | 2 +- > > > xen/arch/arm/arm64/Makefile

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Julien Grall
Hi Jan, On 05/03/2020 09:24, Jan Beulich wrote: On 26.02.2020 12:33, Anthony PERARD wrote: This is part of upgrading our build system and import more of Linux's one. In Linux, subdir-y in Makefiles is only used to descend into subdirectory when there are no object to build, Xen doesn't have

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Andrew Cooper
On 05/03/2020 09:24, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: >> This is part of upgrading our build system and import more of Linux's >> one. >> >> In Linux, subdir-y in Makefiles is only used to descend into >> subdirectory when there are no object to build, Xen doesn't

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-05 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > This is part of upgrading our build system and import more of Linux's > one. > > In Linux, subdir-y in Makefiles is only used to descend into > subdirectory when there are no object to build, Xen doesn't have that > and all subdir have object to be

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-04 Thread Jan Beulich
On 27.02.2020 10:43, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -111,17 +111,14 @@ define gendep >> endef >> $(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) $(extra-y)),$(eval $(call >> gendep,$(o >> >> -# Ensure

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-02-27 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -111,17 +111,14 @@ define gendep > endef > $(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) $(extra-y)),$(eval $(call > gendep,$(o > > -# Ensure each subdirectory has exactly one trailing slash. >

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-02-27 Thread Roger Pau Monné
On Wed, Feb 26, 2020 at 11:33:39AM +, Anthony PERARD wrote: > This is part of upgrading our build system and import more of Linux's > one. > > In Linux, subdir-y in Makefiles is only used to descend into > subdirectory when there are no object to build, Xen doesn't have that > and all subdir

[Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-02-26 Thread Anthony PERARD
This is part of upgrading our build system and import more of Linux's one. In Linux, subdir-y in Makefiles is only used to descend into subdirectory when there are no object to build, Xen doesn't have that and all subdir have object to be included in the final binary. To allow the new syntax,