Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-24 Thread Anthony PERARD
On Mon, Mar 23, 2020 at 04:11:53PM +0100, Roger Pau Monné wrote: > On Thu, Mar 19, 2020 at 04:24:12PM +, Anthony PERARD wrote: > > So, testing for the -Wa,--strip-local-absolute flags turns out to be > > more complicated than I though it would be. > > - cc-option-add doesn't work because it

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-19 Thread Anthony PERARD
On Tue, Mar 17, 2020 at 06:05:24PM +, Anthony PERARD wrote: > On Thu, Feb 27, 2020 at 12:05:04PM +0100, Roger Pau Monné wrote: > > On Wed, Feb 26, 2020 at 11:33:47AM +, Anthony PERARD wrote: > > > +ifneq ($(CONFIG_CC_IS_CLANG),y) > > > +# Clang doesn't understand this command line

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-18 Thread Jan Beulich
On 17.03.2020 19:35, Anthony PERARD wrote: On Wed, Mar 04, 2020 at 04:00:52PM +0100, Jan Beulich wrote: On 26.02.2020 12:33, Anthony PERARD wrote: @@ -113,6 +115,64 @@ $(KCONFIG_CONFIG): +AFLAGS += -D__ASSEMBLY__ + +CFLAGS += $(CFLAGS-y) I can't seem to be able to spot a similar line for

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-17 Thread Anthony PERARD
On Wed, Mar 04, 2020 at 04:00:52PM +0100, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: > > @@ -113,6 +115,64 @@ $(KCONFIG_CONFIG): > > +AFLAGS += -D__ASSEMBLY__ > > + > > +CFLAGS += $(CFLAGS-y) > > I can't seem to be able to spot a similar line for AFLAGS. I didn't add any

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-17 Thread Anthony PERARD
On Thu, Feb 27, 2020 at 12:05:04PM +0100, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 11:33:47AM +, Anthony PERARD wrote: > > +ifeq ($(CONFIG_DEBUG),y) > > +CFLAGS += -O1 > > +else > > +CFLAGS += -O2 > > +endif > > Long term we might want to make the optimization level selectable in >

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > @@ -113,6 +115,64 @@ $(KCONFIG_CONFIG): > include/config/%.conf include/config/%.conf.cmd: $(KCONFIG_CONFIG) > $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) > SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)"

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-02-27 Thread Roger Pau Monné
On Wed, Feb 26, 2020 at 11:33:47AM +, Anthony PERARD wrote: > Instead of generating the CFLAGS in Rules.mk everytime we enter a new > subdirectory, we are going to generate most of them a single time, and > export the result in the environment so that Rules.mk can use it. The > only flags

[Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-02-26 Thread Anthony PERARD
Instead of generating the CFLAGS in Rules.mk everytime we enter a new subdirectory, we are going to generate most of them a single time, and export the result in the environment so that Rules.mk can use it. The only flags left to generates are the one that depends on the targets, but the variable